The branch main has been updated by kp:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=dcc4d2939f789a6d1f272ffeab2068ba2b7525ea

commit dcc4d2939f789a6d1f272ffeab2068ba2b7525ea
Author:     Aaron LI <a...@aaronly.me>
AuthorDate: 2023-11-11 13:13:08 +0000
Commit:     Kristof Provost <k...@freebsd.org>
CommitDate: 2023-11-11 13:13:08 +0000

    if_wg: Missing radix unlock can cause deadlock
    
    In function 'wg_aip_add()', the error path of returning ENOMEM when
    (node == NULL) is forgetting to unlock the radix tree, and thus may lead
    to a deadlock.
    
    PR:             275001
    Reviewed by:    kp
    MFC after:      1 week
---
 sys/dev/wg/if_wg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/wg/if_wg.c b/sys/dev/wg/if_wg.c
index 4a21afe82eb5..0ea40b763416 100644
--- a/sys/dev/wg/if_wg.c
+++ b/sys/dev/wg/if_wg.c
@@ -562,7 +562,7 @@ wg_aip_add(struct wg_softc *sc, struct wg_peer *peer, 
sa_family_t af, const void
                node = root->rnh_lookup(&aip->a_addr, &aip->a_mask, &root->rh);
        if (!node) {
                free(aip, M_WG);
-               return (ENOMEM);
+               ret = ENOMEM;
        } else if (node != aip->a_nodes) {
                free(aip, M_WG);
                aip = (struct wg_aip *)node;

Reply via email to