> On 17. Jul 2023, at 19:54, Warner Losh <i...@bsdimp.com> wrote: > > > > On Mon, Jul 17, 2023 at 11:52 AM John Baldwin <j...@freebsd.org> wrote: > On 7/17/23 10:35 AM, Warner Losh wrote: >> The branch main has been updated by imp: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=d3152ab23e0e7bee5a0f988ecca2a1187ab82057 >> >> commit d3152ab23e0e7bee5a0f988ecca2a1187ab82057 >> Author: Warner Losh <i...@freebsd.org> >> AuthorDate: 2023-07-17 17:22:45 +0000 >> Commit: Warner Losh <i...@freebsd.org> >> CommitDate: 2023-07-17 17:22:45 +0000 >> >> tcbpcb: Always define t_osd >> >> Always define t_osd. congestion control modules access it >> unconditionally. This fixes the build. >> >> However, this is, at best, a temporary band-aide until the >> larger issues are sorted. >> >> Sponsored by: Netflix > > FWIW, I find that #ifdef's based on kernel options in "core" structures like > this > shared with modules is a recipe for disaster. > > Agreed 100% Just trying to get to closure on that concept with all the > concerned > parties.... Just discussed this issue with rrs@. The proposal includes this. Will bring up a review shortly. I will put you on the reviewers list.
Best regards Michael > > Warner
