On 10/10/21 12:34 PM, Konstantin Belousov wrote:
The branch main has been updated by kib:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=e81e77c5a055d1cbf6d6a6f0acbaf443267aa84f

commit e81e77c5a055d1cbf6d6a6f0acbaf443267aa84f
Author:     Konstantin Belousov <k...@freebsd.org>
AuthorDate: 2021-10-10 12:20:45 +0000
Commit:     Konstantin Belousov <k...@freebsd.org>
CommitDate: 2021-10-10 19:34:40 +0000

     Enable PPS_SYNC on amd64, arm64 and armv7
Remove the option from NOTES/LINT, and add to NOTES for powerpc and
     riscv.
PR: 259036
     Requested by:   John Hay <j...@sanren.ac.za>
     Discussed with: ian, imp
     Sponsored by:   The FreeBSD Foundation
     MFC after:      1 week

Hmm, if the option is MI, why move it out of the MI NOTES?  We don't
generally remove items from NOTES just because they are enabled by default
in GENERIC.  That would break the functionality of NOTES where it documents
options (and sometimes provides more detail than the 1-liner comments we
use in GENERIC).

In this case I would have left NOTES as-is and instead added PPS_SYNC to
the relevant GENERIC files with a one-line comment leaving the more
detailed comment in NOTES.

--
John Baldwin

Reply via email to