The branch main has been updated by kevans:
URL:
https://cgit.FreeBSD.org/src/commit/?id=8ca384eb1d429aae866f53abfadafc71ab009dc6
commit 8ca384eb1d429aae866f53abfadafc71ab009dc6
Author: Adam Fenn <a...@fenn.io>
AuthorDate: 2021-08-02 16:27:17 +0000
Commit: Kyle Evans <kev...@freebsd.org>
CommitDate: 2021-08-02 16:27:17 +0000
devclass_alloc_unit: move "at" hint test to after device-in-use test
Only perform this expensive operation when the unit number is a
potential candidate (i.e. not already in use), thereby reducing device
scan time on systems with many devices, unit numbers, and drivers.
Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #61
Differential Revision: https://reviews.freebsd.org/D31381
---
sys/kern/subr_bus.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sys/kern/subr_bus.c b/sys/kern/subr_bus.c
index fc2048561cf6..77b4c4c66c4b 100644
--- a/sys/kern/subr_bus.c
+++ b/sys/kern/subr_bus.c
@@ -1638,15 +1638,15 @@ devclass_alloc_unit(devclass_t dc, device_t dev, int
*unitp)
/* Unwired device, find the next available slot for it */
unit = 0;
for (unit = 0;; unit++) {
+ /* If this device slot is already in use, skip it. */
+ if (unit < dc->maxunit && dc->devices[unit] != NULL)
+ continue;
+
/* If there is an "at" hint for a unit then skip it. */
if (resource_string_value(dc->name, unit, "at", &s) ==
0)
continue;
- /* If this device slot is already in use, skip it. */
- if (unit < dc->maxunit && dc->devices[unit] != NULL)
- continue;
-
break;
}
}
_______________________________________________
dev-commits-src-main@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main
To unsubscribe, send any mail to "dev-commits-src-main-unsubscr...@freebsd.org"
