The branch main has been updated by np:
URL:
https://cgit.FreeBSD.org/src/commit/?id=4a4e9c516cfc54181264c92276301a45ea4680d4
commit 4a4e9c516cfc54181264c92276301a45ea4680d4
Author: Navdeep Parhar <n...@freebsd.org>
AuthorDate: 2021-03-05 19:28:18 +0000
Commit: Navdeep Parhar <n...@freebsd.org>
CommitDate: 2021-03-05 19:28:18 +0000
cxgbe(4): Fix an assertion that is not valid during attach.
Firmware access from t4_attach takes place without any synchronization.
The driver should not panic (debug kernels) if something goes wrong in
early communication with the firmware. It should still load so that
it's possible to poke around with cxgbetool.
MFC after: 1 week
Sponsored by: Chelsio Communications
---
sys/dev/cxgbe/t4_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c
index c9a8b08e8d16..f749fdd937d7 100644
--- a/sys/dev/cxgbe/t4_main.c
+++ b/sys/dev/cxgbe/t4_main.c
@@ -2875,7 +2875,8 @@ t4_fatal_err(struct adapter *sc, bool fw_error)
log(LOG_ALERT, "%s: encountered fatal error, adapter stopped.\n",
device_get_nameunit(sc->dev));
if (fw_error) {
- ASSERT_SYNCHRONIZED_OP(sc);
+ if (sc->flags & CHK_MBOX_ACCESS)
+ ASSERT_SYNCHRONIZED_OP(sc);
sc->flags |= ADAP_ERR;
} else {
ADAPTER_LOCK(sc);
_______________________________________________
dev-commits-src-main@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main
To unsubscribe, send any mail to "dev-commits-src-main-unsubscr...@freebsd.org"
