The branch main has been updated by melifaro:
URL:
https://cgit.FreeBSD.org/src/commit/?id=a375ec52a7b423133f66878ecf002efc3b6e9fca
commit a375ec52a7b423133f66878ecf002efc3b6e9fca
Author: Alexander V. Chernikov <melif...@freebsd.org>
AuthorDate: 2021-02-12 20:56:52 +0000
Commit: Alexander V. Chernikov <melif...@freebsd.org>
CommitDate: 2021-02-13 00:06:14 +0000
Fix ifa refcount leak during route addition.
Reported by: rstone
Reviewed by: rstone
MFC after: 1 day
---
sys/net/route/route_ctl.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sys/net/route/route_ctl.c b/sys/net/route/route_ctl.c
index 6b0869196d12..9aedfb9d5855 100644
--- a/sys/net/route/route_ctl.c
+++ b/sys/net/route/route_ctl.c
@@ -594,14 +594,12 @@ create_rtentry(struct rib_head *rnh, struct rt_addrinfo
*info,
}
error = nhop_create_from_info(rnh, info, &nh);
- if (error != 0) {
- ifa_free(info->rti_ifa);
+ ifa_free(info->rti_ifa);
+ if (error != 0)
return (error);
- }
rt = uma_zalloc(V_rtzone, M_NOWAIT | M_ZERO);
if (rt == NULL) {
- ifa_free(info->rti_ifa);
nhop_free(nh);
return (ENOBUFS);
}
_______________________________________________
dev-commits-src-main@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main
To unsubscribe, send any mail to "dev-commits-src-main-unsubscr...@freebsd.org"
