git: 6b95d258a96b - main - pf tests: test DIOCNATLOOK validation

[Kristof Provost]

The branch main has been updated by kp:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=6b95d258a96b7f3a7d61af5c3fb028194ca8f204

commit 6b95d258a96b7f3a7d61af5c3fb028194ca8f204
Author:     Kristof Provost <k...@freebsd.org>
AuthorDate: 2025-07-03 15:07:52 +0000
Commit:     Kristof Provost <k...@freebsd.org>
CommitDate: 2025-07-09 08:57:49 +0000

    pf tests: test DIOCNATLOOK validation
    
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
---
 tests/sys/netpfil/pf/ioctl/validation.c | 35 +++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/tests/sys/netpfil/pf/ioctl/validation.c 
b/tests/sys/netpfil/pf/ioctl/validation.c
index 1ce8999dcb91..18fafe11c6ab 100644
--- a/tests/sys/netpfil/pf/ioctl/validation.c
+++ b/tests/sys/netpfil/pf/ioctl/validation.c
@@ -32,6 +32,7 @@
 #include <net/if.h>
 #include <net/pfvar.h>
 
+#include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
 
@@ -893,6 +894,39 @@ ATF_TC_CLEANUP(rpool_mtx2, tc)
        COMMON_CLEANUP();
 }
 
+ATF_TC_WITH_CLEANUP(natlook);
+ATF_TC_HEAD(natlook, tc)
+{
+       atf_tc_set_md_var(tc, "require.user", "root");
+}
+
+ATF_TC_BODY(natlook, tc)
+{
+       struct pfioc_natlook nl = { 0 };
+
+       COMMON_HEAD();
+
+       nl.af = AF_INET;
+       nl.proto = IPPROTO_ICMP;
+       nl.saddr.v4.s_addr = 0x01020304;
+       nl.daddr.v4.s_addr = 0x05060708;
+
+       /* Invalid direction */
+       nl.direction = 42;
+
+       ATF_CHECK_ERRNO(EINVAL, ioctl(dev, DIOCNATLOOK, &nl) == -1);
+
+       /* Invalid af */
+       nl.direction = PF_IN;
+       nl.af = 99;
+
+       ATF_CHECK_ERRNO(EAFNOSUPPORT, ioctl(dev, DIOCNATLOOK, &nl) == -1);
+}
+
+ATF_TC_CLEANUP(natlook, tc)
+{
+       COMMON_CLEANUP();
+}
 
 ATF_TP_ADD_TCS(tp)
 {
@@ -918,6 +952,7 @@ ATF_TP_ADD_TCS(tp)
        ATF_TP_ADD_TC(tp, tag);
        ATF_TP_ADD_TC(tp, rpool_mtx);
        ATF_TP_ADD_TC(tp, rpool_mtx2);
+       ATF_TP_ADD_TC(tp, natlook);
 
        return (atf_no_error());
 }