On Wed, Jun 11, 2025 at 07:05:45AM +0300, Konstantin Belousov wrote:
K> On Tue, Jun 10, 2025 at 08:41:44AM -0700, Gleb Smirnoff wrote:
K> > On Tue, Jun 10, 2025 at 12:11:18PM +0300, Konstantin Belousov wrote:
K> > K> Apparently we already have the feature called 'warmstart', where rpcbind
K> > K> can be restarted and existing registrations are reloaded. So it is in
K> > K> fact already solved, assuming admin is careful enough to use -w.
K> >
K> > Ok, then all that needs to be done is revert this:
K> >
K> > --- a/usr.sbin/rpcbind/rpcbind.c
K> > +++ b/usr.sbin/rpcbind/rpcbind.c
K> > @@ -159,10 +159,6 @@ main(int argc, char *argv[])
K> >
K> > update_bound_sa();
K> >
K> > - /* Ensure krpc is loaded */
K> > - if (modfind("krpc") < 0 && kldload("krpc") < 0)
K> > - err(1, "krpc");
K> > -
K> > /* Check that another rpcbind isn't already running. */
K> > if ((rpcbindlockfd = open(RPCBINDDLOCK, O_RDONLY|O_CREAT, 0444)) <
0)
K> > err(1, "%s", RPCBINDDLOCK);
K> Well, absolutely minimal fix would be to change err() to warn().
Kostik, please just commit this. Just one suggestion: make the warn() message
more verbose:
warn("failed to load krpc module, RPC services for kernel disabled");
--
Gleb Smirnoff
