On 5/5/25 09:29, Warner Losh wrote:
On Mon, May 5, 2025, 6:13 AM Olivier Certner <[email protected]> wrote:
- /*-
+ /*
No opinion on which it should be, but the minus character is meaningful
within the context of indent(1) - it won't reformat "block" comments.
Thanks for pointing that out, I didn't know. I think removing them was
OK, as these block comments are really nothing special. Actually, I
probably should have reformatted them to eliminate the margin for all but
the first line.
Almost nobody uses indent these days on a regular basis. We can drop it for
that reason alone, even if the comments were formatted by hand... we likely
need to start tagging those with clang format tags..
Eh, the clang format tags are ugly for this use case. If using CommentPragmas
doesn't already handle this case, I'd rather add a new option to clang-format
to disable reflowing comments when this is present. We already have this
widely used throughout the tree, and it would better to fix the tool than
gratuitous churn. We probably clear clang-format's bar of being a project of
a sufficient size that they will accept patches from us for new formatting
options.
--
John Baldwin
