Yes, it was the previous change, not this one. And yes, simply adding 'acpi_if.h' to the Makefile did the trick. I went ahead and committed it: 9709bda03cd0
Thanks, Ravi (rpokala@) -----Original Message----- From: <owner-src-committ...@freebsd.org <mailto:owner-src-committ...@freebsd.org>> on behalf of Colin Percival <cperc...@freebsd.org <mailto:cperc...@freebsd.org>> Date: Friday, November 1, 2024 at 19:13 To: Ravi Pokala <rpok...@freebsd.org <mailto:rpok...@freebsd.org>>, <src-committ...@freebsd.org <mailto:src-committ...@freebsd.org>>, <dev-commits-src-all@FreeBSD.org <mailto:dev-commits-src-all@FreeBSD.org>>, <dev-commits-src-m...@freebsd.org <mailto:dev-commits-src-m...@freebsd.org>> Subject: Re: 6540ac118473 - main - modules: gpioaei only on ACPI-supporting archs On 11/1/24 18:34, Ravi Pokala wrote: > This seems to have broken arm64.LINT-FDT: > > ================================================================ > % less _.arm64.LINT-FDT > ... > -------------------------------------------------------------- >>>> stage 3.1: building everything > -------------------------------------------------------------- > In file included from > /usr/home/rpokala/freebsd/src/clean-main/sys/dev/gpio//gpioaei.c:37: > /usr/home/rpokala/freebsd/src/clean-main/sys/dev/acpica/acpivar.h:34:10: > fatal error: 'acpi_if.h' file not found > 34 | #include "acpi_if.h" > | ^~~~~~~~~~~ > 1 error generated. > *** [gpioaei.o] Error code 1 > > make[8]: stopped making "all" in > /usr/home/rpokala/freebsd/src/clean-main/sys/modules/gpio/gpioaei Oops. It was probably the earlier commit which broke it, but I'm clearly not good at kernel modules. Can you check if adding "acpi_if.h" to SRCS in src/sys/modules/gpio/gpioaei/Makefile fixes the problem? -- Colin Percival FreeBSD Release Engineering Lead & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
