git: 541d89067add - stable/14 - tcp: Make use of enum for sack_changed

[Richard Scheffenegger]

The branch stable/14 has been updated by rscheff:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=541d89067addcc7fec96214225c82e43d2ce037e

commit 541d89067addcc7fec96214225c82e43d2ce037e
Author:     Richard Scheffenegger <rsch...@freebsd.org>
AuthorDate: 2024-01-06 19:07:39 +0000
Commit:     Richard Scheffenegger <rsch...@freebsd.org>
CommitDate: 2024-01-09 12:54:48 +0000

    tcp: Make use of enum for sack_changed
    
    No functional change.
    
    Reviewed By:           tuexen, #transport
    MFC after:             3 days
    Sponsored by:          NetApp, Inc.
    Differential Revision: https://reviews.freebsd.org/D43346
    
    (cherry picked from commit 893ed42eca32f7b5e3a5b8cef3f364be0d9cf3ef)
---
 sys/netinet/tcp_input.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c
index 512da877846a..2d7a6fa11b4e 100644
--- a/sys/netinet/tcp_input.c
+++ b/sys/netinet/tcp_input.c
@@ -2506,7 +2506,8 @@ tcp_do_segment(struct tcpcb *tp, struct mbuf *m, struct 
tcphdr *th,
                        goto dropafterack;
                }
                if (tcp_is_sack_recovery(tp, &to)) {
-                       if (((sack_changed = tcp_sack_doack(tp, &to, 
th->th_ack)) != 0) &&
+                       sack_changed = tcp_sack_doack(tp, &to, th->th_ack);
+                       if ((sack_changed != SACK_NOCHANGE) &&
                            (tp->t_flags & TF_LRD)) {
                                tcp_sack_lost_retransmission(tp, th);
                        }