The branch stable/14 has been updated by kevans:
URL:
https://cgit.FreeBSD.org/src/commit/?id=346112fe3d7ad77001e815e87c74996f8f04cb25
commit 346112fe3d7ad77001e815e87c74996f8f04cb25
Author: Kyle Evans <kev...@freebsd.org>
AuthorDate: 2023-12-13 16:49:03 +0000
Commit: Kyle Evans <kev...@freebsd.org>
CommitDate: 2024-01-03 04:47:21 +0000
kdump: use print_mask_arg0 appropriately
Some callers are using print_mask_arg() when they should be using
print_mask_arg0(); the latter should be used when all flags are optional
and there's not a flag to be decoded with a 0-mask. This turns:
nmount(0x6991e009000,0x8,0<><invalid>0)
into:
nmount(0x6991e009000,0x8,0)
Reviewed by: jhb
(cherry picked from commit a206524709bdfbd577bcfe76676da80b8250f84c)
---
usr.bin/kdump/kdump.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/usr.bin/kdump/kdump.c b/usr.bin/kdump/kdump.c
index cb8f5ff1f537..078b8a364db8 100644
--- a/usr.bin/kdump/kdump.c
+++ b/usr.bin/kdump/kdump.c
@@ -934,7 +934,8 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t
**resip,
print_number(ip, narg, c);
print_number(ip, narg, c);
putchar(',');
- print_mask_arg(sysdecode_close_range_flags,
*ip);
+ print_mask_arg0(sysdecode_close_range_flags,
+ *ip);
ip += 3;
narg -= 3;
break;
@@ -1000,14 +1001,14 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t
**resip,
print_number(ip, narg, c);
print_number(ip, narg, c);
putchar(',');
- print_mask_arg(sysdecode_mount_flags, *ip);
+ print_mask_arg0(sysdecode_mount_flags, *ip);
ip++;
narg--;
break;
case SYS_unmount:
print_number(ip, narg, c);
putchar(',');
- print_mask_arg(sysdecode_mount_flags, *ip);
+ print_mask_arg0(sysdecode_mount_flags, *ip);
ip++;
narg--;
break;
@@ -1465,7 +1466,7 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t
**resip,
print_number(ip, narg, c);
print_number(ip, narg, c);
putchar(',');
- print_mask_arg(sysdecode_mount_flags, *ip);
+ print_mask_arg0(sysdecode_mount_flags, *ip);
ip++;
narg--;
break;
