On 19 Oct 2023, at 15:20, Kristof Provost <k...@freebsd.org> wrote:
> 
> The branch main has been updated by kp:
> 
> URL: 
> https://cgit.FreeBSD.org/src/commit/?id=9eff6390718d0fa67dffc6cd830b0bc6b815e8c4
> 
> commit 9eff6390718d0fa67dffc6cd830b0bc6b815e8c4
> Author:     Kristof Provost <k...@freebsd.org>
> AuthorDate: 2023-10-19 10:06:29 +0000
> Commit:     Kristof Provost <k...@freebsd.org>
> CommitDate: 2023-10-19 14:19:39 +0000
> 
>    pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h
> 
>    When userspace includes pfvar.h it doesn't get the kernel's COMPAT_*
>    defines, so we end up not having required symbols in userspace. This
>    caused the libpfctl port to fail to build.
> 
>    libpfctl will be updated to use the new netlink-based state export code
>    soon, which will also fix thix build issue.
> 
>    Sponsored by:   Rubicon Communications, LLC ("Netgate")

That’s normally a feature to stop userspace using deprecated things.
Will you be reverting this once libpfctl is fixed? One could also hack
libpfctl instead to define COMPAT_FREEBSD14 temporarily (IIRC that’s
what was done for kbdcontrol to allow it to run on old kernels).

Jess


Reply via email to