git: 1dca3a9406f1 - stable/13 - vfs cache: retire dothits and dotdothits counters

[Mateusz Guzik]

The branch stable/13 has been updated by mjg:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=1dca3a9406f12168919bdcafdb45cbbb613e9c8c

commit 1dca3a9406f12168919bdcafdb45cbbb613e9c8c
Author:     Mateusz Guzik <m...@freebsd.org>
AuthorDate: 2023-09-23 00:08:49 +0000
Commit:     Mateusz Guzik <m...@freebsd.org>
CommitDate: 2023-10-13 23:48:12 +0000

    vfs cache: retire dothits and dotdothits counters
    
    They demonstrate nothing, and in case of dotdot they are not even hits.
    This is just a count of lookups with "..", which are not worth
    mentioniong.
    
    (cherry picked from commit bb124a0f611a1288c8496e3b33494f23ba929ca1)
---
 sys/kern/vfs_cache.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c
index 671451cadabc..29f14fb931e6 100644
--- a/sys/kern/vfs_cache.c
+++ b/sys/kern/vfs_cache.c
@@ -534,8 +534,6 @@ STATNODE_ULONG(neg, numneg, "Number of negative cache 
entries");
 STATNODE_ULONG(count, numcache, "Number of cache entries");
 STATNODE_COUNTER(heldvnodes, numcachehv, "Number of namecache entries with 
vnodes held");
 STATNODE_COUNTER(drops, numdrops, "Number of dropped entries due to reaching 
the limit");
-STATNODE_COUNTER(dothits, dothits, "Number of '.' hits");
-STATNODE_COUNTER(dotdothits, dotdothits, "Number of '..' hits");
 STATNODE_COUNTER(miss, nummiss, "Number of cache misses");
 STATNODE_COUNTER(misszap, nummisszap, "Number of cache misses we do not want 
to cache");
 STATNODE_COUNTER(poszaps, numposzaps,
@@ -1786,7 +1784,6 @@ cache_lookup_dot(struct vnode *dvp, struct vnode **vpp, 
struct componentname *cn
        int ltype;
 
        *vpp = dvp;
-       counter_u64_add(dothits, 1);
        SDT_PROBE3(vfs, namecache, lookup, hit, dvp, ".", *vpp);
        if (tsp != NULL)
                timespecclear(tsp);
@@ -1831,7 +1828,6 @@ cache_lookup_dotdot(struct vnode *dvp, struct vnode 
**vpp, struct componentname
                return (0);
        }
 
-       counter_u64_add(dotdothits, 1);
 retry:
        dvlp = VP2VNODELOCK(dvp);
        mtx_lock(dvlp);
@@ -5078,7 +5074,6 @@ cache_fplookup_dot(struct cache_fpl *fpl)
        fpl->tvp = fpl->dvp;
        fpl->tvp_seqc = fpl->dvp_seqc;
 
-       counter_u64_add(dothits, 1);
        SDT_PROBE3(vfs, namecache, lookup, hit, fpl->dvp, ".", fpl->dvp);
 
        error = 0;
@@ -5167,7 +5162,6 @@ cache_fplookup_dotdot(struct cache_fpl *fpl)
                return (cache_fpl_aborted(fpl));
        }
 
-       counter_u64_add(dotdothits, 1);
        return (0);
 }