Hi Martin, The commit message says "what", not "why".
Why was block cloning disabled by default before, and why is it being enabled now? Thanks, Ravi (rpokala@) -----Original Message----- From: <owner-src-committ...@freebsd.org <mailto:owner-src-committ...@freebsd.org>> on behalf of Martin Matuska <m...@freebsd.org <mailto:m...@freebsd.org>> Date: Wednesday, October 11, 2023 at 04:17 To: <src-committ...@freebsd.org <mailto:src-committ...@freebsd.org>>, <dev-commits-src-all@FreeBSD.org <mailto:dev-commits-src-all@FreeBSD.org>>, <dev-commits-src-m...@freebsd.org <mailto:dev-commits-src-m...@freebsd.org>> Subject: git: 26103ccba8b7 - main - zfs: enable block cloning by default The branch main has been updated by mm: URL: https://cgit.FreeBSD.org/src/commit/?id=26103ccba8b75038bd83773268524ac814bfa334 <https://cgit.FreeBSD.org/src/commit/?id=26103ccba8b75038bd83773268524ac814bfa334> commit 26103ccba8b75038bd83773268524ac814bfa334 Author: Martin Matuska <m...@freebsd.org <mailto:m...@freebsd.org>> AuthorDate: 2023-10-10 22:43:35 +0000 Commit: Martin Matuska <m...@freebsd.org <mailto:m...@freebsd.org>> CommitDate: 2023-10-10 22:43:35 +0000 zfs: enable block cloning by default Discussed with: markj Reviewed by: mav Tested by: mm (FreeBSD test suite + OpenZFS test suite) MFC after: 2 months Differential Revision: https://reviews.freebsd.org/D41991 <https://reviews.freebsd.org/D41991> --- sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c index 8969fd6a54bd..09e18de81748 100644 --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c @@ -89,7 +89,7 @@ int zfs_debug_level; SYSCTL_INT(_vfs_zfs, OID_AUTO, debug, CTLFLAG_RWTUN, &zfs_debug_level, 0, "Debug level"); -int zfs_bclone_enabled; +int zfs_bclone_enabled = 1; SYSCTL_INT(_vfs_zfs, OID_AUTO, bclone_enabled, CTLFLAG_RWTUN, &zfs_bclone_enabled, 0, "Enable block cloning");
