On Tue, Apr 12, 2022, 7:07 PM Ravi Pokala <rpok...@freebsd.org> wrote:
> -----Original Message----- > From: Kyle Evans <kev...@freebsd.org> > Date: 2022-04-12, Tuesday at 18:04 > To: Ravi Pokala <rpok...@freebsd.org> > Cc: src-committers <src-committ...@freebsd.org>, "< > dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, < > dev-commits-src-m...@freebsd.org> > Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing > around > > On Tue, Apr 12, 2022 at 7:57 PM Ravi Pokala <rpok...@freebsd.org> > wrote: > > > > -----Original Message----- > > From: <owner-src-committ...@freebsd.org> on behalf of Kyle Evans > <kev...@freebsd.org> > > Date: 2022-04-12, Tuesday at 17:34 > > To: <src-committ...@freebsd.org>, <dev-commits-src-all@FreeBSD.org>, > <dev-commits-src-m...@freebsd.org> > > Subject: git: 454630c72556 - main - stand: libefi: swap /Pci() > printing around > > > > The branch main has been updated by kevans: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=454630c72556d45e401f29f56b3317c2fb0499a0 > > > > commit 454630c72556d45e401f29f56b3317c2fb0499a0 > > Author: Kyle Evans <kev...@freebsd.org> > > AuthorDate: 2022-04-13 00:29:54 +0000 > > Commit: Kyle Evans <kev...@freebsd.org> > > CommitDate: 2022-04-13 00:30:30 +0000 > > > > stand: libefi: swap /Pci() printing around > > > > Printing device followed by interface matches, e.g., edk2. > Note that > > this is only a fallback, many firmware implementations will > provide the > > protocol that we'll use to format device paths. > > > > "(device,function)" makes more sense anyway, since that's the > logical organization (i.e. each unique device may have multiple functions). > > > > What was the rationale for doing "(function,device)" in the first > place? > > > > Based on tsoome's reaction when I pointed it out, the rationale was > "whoops" :-) > > That's a perfectly valid rationale! ;-) > Yea, this is a big table of stuff that's tedious to fill in. Since it isn't usually used, the mistake lay dormant. Woops indeed Warner -Ravi (rpokala@) > > >
