if it never fails it should return void On 7/8/21, Kristof Provost <k...@freebsd.org> wrote: > The branch main has been updated by kp: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=fa96701c8abbc29aad7f8f8d6b823bd7f89c6c15 > > commit fa96701c8abbc29aad7f8f8d6b823bd7f89c6c15 > Author: Kristof Provost <k...@freebsd.org> > AuthorDate: 2021-07-05 12:21:03 +0000 > Commit: Kristof Provost <k...@freebsd.org> > CommitDate: 2021-07-08 08:32:42 +0000 > > pf: Handle errors returned by pf_killstates() > > Happily this wasn't a real bug, because pf_killstates() never fails, > but > we should check the return value anyway, in case it does ever start > returning errors. > > Reported by: clang --analyze > MFC after: 1 week > Sponsored by: Rubicon Communications, LLC ("Netgate") > --- > sys/netpfil/pf/pf_ioctl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c > index 19b92e932052..fece41e917e5 100644 > --- a/sys/netpfil/pf/pf_ioctl.c > +++ b/sys/netpfil/pf/pf_ioctl.c > @@ -4887,6 +4887,8 @@ pf_killstates_nv(struct pfioc_nv *nv) > ERROUT(error); > > error = pf_killstates(&kill, &killed); > + if (error) > + ERROUT(error); > > free(nvlpacked, M_NVLIST); > nvlpacked = NULL; >
-- Mateusz Guzik <mjguzik gmail.com> _______________________________________________ dev-commits-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all To unsubscribe, send any mail to "dev-commits-src-all-unsubscr...@freebsd.org"
