Hi joe, > On May 19, 2021, at 9:42 PM, Joe Clarke <jcla...@marcuscom.com> wrote: > > On 5/19/21 01:54, Lutz Donnerhacke wrote: >> On Tue, May 18, 2021 at 07:51:38PM -0400, Joe Clarke wrote: >>> Just out of curiosity, why remove the RFC reference from the comment? >> >> May you please include the author of the change for such questions? >> >>>> commit 3d846e48227e2e78c1e7b35145f57353ffda56ba >>>> Author: Zhenlei Huang <zlei.hu...@gmail.com> >>>> AuthorDate: 2021-05-18 20:51:37 +0000 >>>> Commit: Lutz Donnerhacke <don...@freebsd.org> >>>> CommitDate: 2021-05-18 20:59:46 +0000 >>>> >>>> The current implement of ip_input() reject packets destined for >>>> 169.254.0.0/16, but not those original from 169.254.0.0/16 link-local >>>> addresses. >>>> >>>> Fix to fully respect RFC 3927 section 2.7. >>>> >>>> PR: 255388 >>>> Reviewed by: donner, rgrimes, karels >>>> MFC after: 1 month >>>> Differential Revision: https://reviews.freebsd.org/D29968 >> >> I did only commit this differential, but set a month for MFC, exactly to >> have to opportunity to fix such mistakes. >> > > IMHO, I'd like to see the RFC reference remain. I see rgrimes response > that the RFC's can change with errata and bis docs, but the anchor still > provides additional context that one can use to learn more about why > this code exists, and they can chase any future forward references. RFC's indeed change, and I think it is common in network stack. Then we need guidelines to better regulate these. CC rgrimes . > > It was there in the initial code, and the commit message saw fit to > reference it again. Removing it just seems like lost context. To track down the changes of the code, I'd personally prefer git-blame. There's still RFC reference in the git commit message, though it is not fully consistent with the comments in the diff. > > Joe > > -- > PGP Key : http://www.marcuscom.com/pgp.asc
_______________________________________________ dev-commits-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all To unsubscribe, send any mail to "dev-commits-src-all-unsubscr...@freebsd.org"
