This seems like an appropriate fix for future releases. However, is it appropriate for SRU? Won't it change existing behaviour for existing users?
> We happened to have some devices having Mic Mute key untranslated by hwdb, typically we just add entries in hwdb to fix the issue This seems like a more appropriate solution for existing stable releases, no? > Since mic mute key is forcibly translated to F20 despite of hardware, if there's any application using that key for other features, it may be in conflict. Well, exactly. This suggests that this is inappropriate for SRU. From https://documentation.ubuntu.com/sru/en/latest/explanation/requirements/#minimal- changes-only: "In line with this, the requirements for stable updates are not necessarily the same as those in the development release. When preparing future releases, one of our goals is to construct the most elegant and maintainable system possible, and this often involves fundamental improvements to the system’s architecture, rearranging packages to avoid bundled copies of other software so that we only have to maintain it in one place, and so on. However, once we have completed a release, the priority is normally to minimise risk caused by changes not explicitly required to fix qualifying bugs, and this tends to be well-correlated with minimising the size of those changes. As such, the same bug may need to be fixed in different ways in stable and development releases." Given the above, I think you need deeper justification as to why this is the correct fix for existing stable releases. ** Changed in: xserver-xorg-input-libinput (Ubuntu Noble) Status: In Progress => Incomplete ** Changed in: xserver-xorg-input-libinput (Ubuntu Oracular) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to xserver-xorg-input-libinput in Ubuntu. https://bugs.launchpad.net/bugs/2103967 Title: [SRU] Include a patch that forcibly maps mic mute key and touchpad function keys to F20-F23 Status in OEM Priority Project: In Progress Status in xserver-xorg-input-libinput package in Ubuntu: Fix Released Status in xserver-xorg-input-libinput source package in Noble: Incomplete Status in xserver-xorg-input-libinput source package in Oracular: Incomplete Status in xserver-xorg-input-libinput source package in Plucky: Fix Released Bug description: [ Impact ] == Background == * Xorg does not take keycodes > 255, where Mic Mute is mapped to 256 by evdev * xkeyboard-config remapped the key to F20 since this patch: https://bugs.freedesktop.org/show_bug.cgi?id=54171 along with other hardware-specific hacks in hwdb. == Current status == * We happened to have some devices having Mic Mute key untranslated by hwdb, typically we just add entries in hwdb to fix the issue * Systemd devs decided not to translate the key to F20 anymore, the translation task is pushed to xserver-xorg-input-libinput for Xorg. We would like to include a patch, so that xserver-xorg-input-libinput can do translation for Xorg, which we could leverage it for enabling Mic Mute key in future hardware. [ Test Plan ] * Find a device that does not have Mic Mute key translated by hwdb, starts Desktop in Xorg mode * Test that mic mute does not work * Update the package to -proposed and restart desktop, test the same key, the mic mute key should work to mute the microphone. [ Where problems could occur ] * Since mic mute key is forcibly translated to F20 despite of hardware, if there's any application using that key for other features, it may be in conflict. [ Other information ] * Changeset https://gitlab.freedesktop.org/xorg/driver/xf86-input- libinput/-/commit/cb80d7f82d35f8068e06d45860ed958a948e15bf * This changeset has been included in plucky To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2103967/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
