This bug was fixed in the package gdm3 - 46.2-1ubuntu1~24.04.1

---------------
gdm3 (46.2-1ubuntu1~24.04.1) noble; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * No-change backport of stable release 46.2 (LP: #2090876)

  [ Jeremy Bícha ]
  * Branch for noble

  [ Alessandro Astone ]
  * Default nvidia hybrid laptops to Xorg (LP: #2080498):
    - Drop Revert-data-Disable-GDM-on-hybrid-graphics-laptops-with-v.patch
      The hunks that are still relevant have been split into their own patches.
    - Add Prefer-Xorg-for-all-Nvidia-versions.patch
      This diff comes directly from the dropped patch.
    - Add Drop-Nvidia-power-management-suspend-checks.patch
      This diff comes directly from the dropped patch, and is still necessary
      to keep Wayland as an option on nvidia >= 470 (both desktops and laptops).
    - Add Drop-special-handling-of-nvidia-hybrid-laptops.patch
      Align nvidia hybrid laptops with nvidia desktops: that means
      disabling Wayland on nvidia < 470 and keeping it opt-in on nvidia >= 470.
      Upstream also did this with GNOME 47, with the difference that there the
      desktop defaults are different.

  [ Nathan Pratta Teodosio ]
  * Rewrite xresources_is_a_dir.patch.
    To fix failure to load files in /etc/X11/Xresources (in case the latter is
    a directory instead of a regular file). (LP: #1955850)

gdm3 (46.2-1ubuntu1) oracular; urgency=medium

  * Merge with Debian, containing new upstream release. Remaining changes:
    + readme.debian: update for correct paths in ubuntu
    + control.in:
      - don't recommend desktop-base
      - depend on bash for config_error_dialog.patch
      - update vcs field
    + rules:
      - don't override default user/group
      - -dgdm-xsession=true to install upstream xsession script
      - override dh_installinit with --no-start to avoid session being killed
    + rules, readme.debian, gdm3.8.pod:
      use upstream custom.conf instead of daemon.conf
    + gdm3.{postinst,postrm}: rename user and group back to gdm
    + debian/tests/control:
      - Use gdm user name
      - Use needs-root instead of needs-sudo (to remove when ubuntu autopkgtest
        will be updated to include such feature)
    + debian/tests/sssd-gdm-smartcard-pam-auth-tester-env.sh:
      - Added to use needs-root autopkgtest instead of needs-sudo
    + gdm3.*.pam: make pam_env read ~/.pam_environment, as we use in g-c-c
      settings
    + gdm3.install:
      - don't install debian/xsession
    + add run_xsession.d.patch
    + add xresources_is_a_dir.patch
      - fix loading from /etc/x11/xresources/*
    + add nvidia_prime.patch:
      - add hook to run prime-offload (as root) and prime-switch if
        nvidia-prime is installed
    + add revert_override_lang_with_accountservices.patch:
      - on ubuntu accountservices only stores the language and not the
        full locale as needed by lang.
    + add dont_set_language_env.patch:
      - don't run the set_up_session_language() function, since it
        overrides variable values set by ~/.pam_environment
    + add config_error_dialog.patch:
      - show warning dialog in case of error in ~/.profile etc. and
        don't let a syntax error make the login fail
    + add debian/patches/revert_nvidia_wayland_blacklist.patch:
      - don't blacklist nvidia for wayland
    + add gdm3.service-wait-for-drm-device-before-trying-to-start-i.patch:
      - wait for the first valid gdm device on pre-start
    + add prefer_ubuntu_session_fallback.patch:
      - Prefer ubuntu session as fallback instead of GNOME
    + add XSession-Use-x-terminal-emulator-as-fallback-instead-of-x.patch:
      - Use x-terminal-emulator as fallback instead of xterm
    + add Revert-data-Disable-GDM-on-hybrid-graphics-laptops-with-v.patch:
      - Ensure Nvidia 5xx drivers always get Wayland as the default unless
        there's a stronger reason why it won't work (like modeset has been
        disabled on the kernel command line)
    + add debian/default.pa
      - disable bluetooth audio devices in pulseaudio from gdm3.
    + debian/gdm3.install
      - added details of the default.pa file
    + debian/gdm3.postinst
      - added installation of default.pa and creation of dir if it doesn't
        exist.
    + debian/greeter.dconf-defaults: don't set debian settings in the
      greeter's dconf db
    * Reverted debian patch to udev rules for nvidia S0ix suspend support

gdm3 (46.2-1) unstable; urgency=medium

  [ Jeremy Bícha ]
  * New upstream release
  * Drop 2 patches applied in new release

  [ Sebastian Andrzej Siewior ]
  * Adapt autopkgtest for openssl3.2 (Closes: #1061458)

gdm3 (46.0-2ubuntu2) oracular; urgency=medium

  * Remove the Ubuntu-specific rules that made Xorg the default for Nvidia.
    Updated Revert-data-Disable-GDM-on-hybrid-graphics-laptops-with-v.patch
    to ensure Nvidia 5xx drivers always get Wayland as the default unless
    there's a stronger reason why it won't work (like modeset has been
    disabled on the kernel command line).
    Also refresh the patch description with a more recent justification.
    (LP: #2080498)

 -- Marco Trevisan (Treviño) <ma...@ubuntu.com>  Mon, 02 Dec 2024
23:47:57 +0100

** Changed in: gdm3 (Ubuntu Noble)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1955850

Title:
  /etc/X11/Xresources no longer loaded, error in patch

Status in gdm3 package in Ubuntu:
  Fix Released
Status in gdm3 source package in Noble:
  Fix Released
Status in gdm3 source package in Oracular:
  Fix Released

Bug description:
  Impact
  ------

  Files in the /etc/X11/Xresources directory stopped being automatically
  loaded into the X resource database by GDM.

  This typically causes changes in the user interface of multiple
  programs; There are also parameters for fonts, including sclaing
  (Xft.dpi) and mouse pointer size (XCursor.size). There is of course no
  exhaustively listing the impact as each program can use arbitrary
  entries in the database and alter its behavior as desired, not only
  limited to the GUI (e.g. XTerm*saveLines).

  Test case
  ---------

  *Install the GDM update from proposed.
  *Create the file /etc/X11/Xresources/m with the following contents:
    XTerm*Foreground: white
    XTerm*Background: darkblue
  *[This will kill your graphical session in a standard Ubuntu setup] Execute 
'systemctl restart gdm'.
  *Log in as usual.
  *Start XTerm.

  XTerm launches, has a dark blue background and a white font.

  Regression potential
  --------------------

  The main potential here is that files in that directory that were not
  loaded before (because they did not match a pattern) would now be.

  Original report
  ---------------

  After upgrading from 21.04 to 21.10, my /etc/X11/Xresources/ directory
  no longer loads on login.

  Looking at the sources, I think this can be traced to:
   - Switching from a custom Xsession file to the upstream Xsession file in 
3.38.0-1ubuntu1, combined with
   - An oversight in `debian/patches/ubuntu/xresources_is_a_dir.patch`

  Looking at [that patch](https://salsa.debian.org/gnome-
  
team/gdm/-/blob/ubuntu/master/debian/patches/ubuntu/xresources_is_a_dir.patch),
  it has:

  ```diff
  --- a/data/Xsession.in
  +++ b/data/Xsession.in
  @@ -122,6 +122,13 @@ fi

   if [ -f "$sysresources" ]; then
       xrdb -nocpp -merge "$sysresources"
  +elif [ -d "$sysresources" ]; then
  +    # directory of Xresources files on Debian/Ubuntu
  +    for i in `ls "$sysresources"` ; do
  +        if [ -r "$sysresources/$i"  -a -f "$sysresources/$i" ] && expr "$i" 
: '^[[:alnum:]_-]\+$' > /dev/null; then
  +            xrdb -nocpp -merge "$sysresources/$i"
  +        fi
  +    done
   fi

   if [ -f "$userresources" ]; then
  ```

  However, looking a few lines further up in [the original Xsession.in
  file](https://salsa.debian.org/gnome-
  team/gdm/-/blob/ubuntu/master/data/Xsession.in#L97), I see:

  ```sh
  if [ -f /etc/X11/Xresources ]; then
      sysresources=/etc/X11/Xresources
  else
      sysresources=/usr/etc/X11/Xresources
  fi
  ```

  In other words, if `/etc/X11/Xresources` is a directory, the
  `sysresources` variable is never set correctly, so the patch should
  also modify this part of the script.

  I have observed this broken behavior on version 41~rc-0ubuntu2, but
  looking at the ubuntu/master branch (as linked above), it still seems
  broken there.

  I'm currently testing this patch:

  ```diff
  --- Xsession.orig       2021-12-27 22:05:09.038863375 +0100
  +++ Xsession    2021-12-27 22:05:33.143057433 +0100
  @@ -111,7 +111,7 @@
   usermodmap="$HOME/.Xmodmap"
   userxkbmap="$HOME/.Xkbmap"

  -if [ -f /etc/X11/Xresources ]; then
  +if [ -e /etc/X11/Xresources ]; then
       sysresources=/etc/X11/Xresources
   else
       sysresources=/usr/etc/X11/Xresources
  ```

  I don't know if it works yet, since I need to log out for that, and
  close my browser, so need to submit this report first ;-)

  ```
  $ lsb_release -rd
  Description:    Ubuntu 21.10
  Release:        21.10
  $ apt-cache policy gdm3
  gdm3:
    Installed: 41~rc-0ubuntu2
    Candidate: 41~rc-0ubuntu2
    Version table:
   *** 41~rc-0ubuntu2 500
          500 http://nl.archive.ubuntu.com/ubuntu impish/main amd64 Packages
          100 /var/lib/dpkg/status
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1955850/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to