Hi Jan, I am also involved as a reviewer in the portal PR you
referenced, so we can continue the discussion there (my Github handle is
`Rob--W` ).

> I wonder if having the GetManifest() and Start() actually makes any
sense in the Firefox. Could be sufficient enough to pass the manifest
lookup and parsing to the portal and from the Firefox side only use
CreateSession(requested_webextension_name,
extension_id)->GetPipes()->Close() methods?

It is an intentional design decision to forward the full native
messaging manifest from the portal to the browser/Firefox, because it
offers all relevant information to Firefox. The portal's primary
responsibility is to do things that Firefox cannot, which is launching
applications outside of the confinement. The fact that the portal should
and does also perform additional validation does not preclude Firefox
from doing the same. The relevant discussion is in this thread on an old
revision of the patch:
https://phabricator.services.mozilla.com/D140803?id=626421#inline-868567

> He also brought idea to have webextension itself in the flatpak where
we hit that the json files won't be accessible from the host system. The
webextensions then will have to implement dbus interface to pass pipes
(as it works with this patch) and the flatpak portal could stay in
between to make it happen. From the Firefox point of view it won't
require any additional changes. Only portal have to do all the lifting.

I assume that by "webextension itself" you meant the native messaging
host application (i.e. the native application outside of Firefox that an
extension wishes to launch)? At some point, the host system needs to be
able to discover which applications are able to talk with Firefox. The
standard format for that is the native messaging manifest. It is up to
the portal to pass a valid manifest to a confined Firefox, whether it is
a real one, or a fake one that fits the required properties.

Since this discussion is only relevant to the portal and independent of
Firefox, let's not comment on a closed bug in Firefox and continue the
discussion after https://github.com/flatpak/xdg-desktop-
portal/pull/705#issuecomment-2531614055

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1741074

Title:
  [snap] chrome-gnome-shell extension fails to detect native host
  connector

Status in Mozilla Firefox:
  Fix Released
Status in KeePassXC Snap Builds:
  Unknown
Status in chromium-browser package in Ubuntu:
  Triaged
Status in firefox package in Ubuntu:
  In Progress
Status in goopg package in Ubuntu:
  Confirmed
Status in kdeconnect package in Ubuntu:
  Confirmed
Status in plasma-browser-integration package in Ubuntu:
  Confirmed

Bug description:
  (initially reported at https://forum.snapcraft.io/t/chrome-gnome-
  shell-does-not-work-with-chromium-snap/3377)

  See attached screenshot.

  [Workaround]
  If you're using Ubuntu 22.04 LTS, you can install GNOME Shell extensions with 
this app.

  sudo apt install gnome-shell-extension-manager

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1741074/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to