Launchpad has imported 26 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1933823.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2024-11-27T21:32:41+00:00 Robert Mader wrote: I haven't bisected yet when it happened, but at some point after the last ESR release and current nightly the opaque region broke - see pictures below. It should cover most of the window whenever possible, creating drawing overhead in compositors otherwise. This is particular painful on Wayland, where compositors lose several optimization options (but it also happens on X11). Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/5 ------------------------------------------------------------------------ On 2024-11-27T21:37:47+00:00 Robert Mader wrote: Created attachment 9440312 Nigtly 135 Wayland with gnome opaque region overlay On Gnome the opaque region overlay can be enabled via `alt`+`f2`->`lg`->`Flags`->`OPAQUE_REGION`, making debugging a bit easier. Note that not only most of the window is not covered, there's also a small rectangle in the top-left which shouldn't be there in maximized mode. In fullscreen mode the whole window isn't covered. Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/6 ------------------------------------------------------------------------ On 2024-11-27T21:38:22+00:00 Robert Mader wrote: Created attachment 9440313 Nightly 135 X11 backend Pretty much the same Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/7 ------------------------------------------------------------------------ On 2024-11-27T22:04:15+00:00 Emilio wrote: Obvious candidate would be https://bugzilla.mozilla.org/show_bug.cgi?id=1891414... Though I did test that at the time (on kwin) and confirmed that tweaking the opaque region wrongly caused the window to be mispainted and so on... Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/8 ------------------------------------------------------------------------ On 2024-11-27T22:08:50+00:00 Emilio wrote: There's also the possibility that a frontend change could've made this show up... Or some coordinate system mess up that doesn't happen on kwin... I'll take a look at it as time allows but probably not before next week. Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/9 ------------------------------------------------------------------------ On 2024-11-27T22:12:26+00:00 Emilio wrote: So it seems like we're setting the titlebar to opaque correctly (assuming green is opaque), but somehow not the web content area. And on top of that, on Wayland there seems to be a DPI messup where we double the height somehow. Are you on hidpi? With or without fractional scaling enabled? Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/10 ------------------------------------------------------------------------ On 2024-11-27T22:55:49+00:00 Emilio wrote: Hah, this fixes it for me, can you confirm? ``` diff --git a/browser/themes/shared/sidebar.css b/browser/themes/shared/sidebar.css index 87da71a2842d2..7711fb3ebddfc 100644 --- a/browser/themes/shared/sidebar.css +++ b/browser/themes/shared/sidebar.css @@ -225,7 +225,7 @@ sidebar-main, #sidebar-splitter, #tabbrowser-tabbox { transform-origin: 0 0; - will-change: translate; + /* will-change: translate; */ } #sidebar-main { ``` Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/11 ------------------------------------------------------------------------ On 2024-11-27T23:42:53+00:00 Release-mgmt-account-bot wrote: Set release status flags based on info from the regressing bug 1915230 Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/12 ------------------------------------------------------------------------ On 2024-11-28T00:11:49+00:00 Robert Mader wrote: > Hah, this fixes it for me, can you confirm? Nice, thanks a lot for directly jumping on it! I must confess that I'd need to do a full new setup and thus can't quickly test - but if you do a try build I'm happy to test. > Are you on hidpi? With or without fractional scaling enabled? Yeah, this is on 125% ( `widget.wayland.fractional-scale.enabled` disabled) and the opaque region seem to be scaled a bit wrong indeed :) Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/13 ------------------------------------------------------------------------ On 2024-11-28T11:54:06+00:00 David Turner wrote: I've just checked and for me commenting the `will-change: translate;` line makes the opaque region (as shown by GNOME's OPAQUE_REGION debug display) cover the whole window instead of just the top bar. Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/14 ------------------------------------------------------------------------ On 2024-11-28T12:24:46+00:00 Emilio wrote: Latest nightly should has fixed this for me (mostly by accident, via bug 1908471), can you confirm? Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/15 ------------------------------------------------------------------------ On 2024-11-28T12:34:49+00:00 Robert Mader wrote: Created attachment 9440460 Screenshot From 2024-11-28 13-29-04.png Yep, can confirm it's mostly fixed, thanks! \o/ Just the top-left and top-right corners remain for me - both in maximized and fullscreen mode. Especially the later is unfortunate as it will often prevent compositors to scan out the content surface, often essentially doubling GPU writes. But if you prefer I can open a new bug for that. Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/16 ------------------------------------------------------------------------ On 2024-11-28T13:01:57+00:00 Emilio wrote: I think that's trivial. Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/17 ------------------------------------------------------------------------ On 2024-11-28T13:02:15+00:00 Emilio wrote: Created attachment 9440469 Bug 1933823 - Remove titlebar special-case for opaque region handling. r=rmader,stransky Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/18 ------------------------------------------------------------------------ On 2024-11-28T13:52:45+00:00 Robert Mader wrote: Created attachment 9440490 Screenshot From 2024-11-28 14-51-00.png (In reply to Emilio Cobos Álvarez (:emilio) from comment #12) > I think that's trivial. Hm, not sure if that works - we still have rounded corners in floating mode and we still want to cut them out, no? BTW., I just noticed that the opaque region is now completely gone in floating mode :/ Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/19 ------------------------------------------------------------------------ On 2024-11-28T13:58:51+00:00 Emilio wrote: > Hm, not sure if that works - we still have rounded corners in floating mode and we still want to cut them out, no? That should work because gecko will not consider the navbar to be opaque due to the rounded clip. > BTW., I just noticed that the opaque region is now completely gone in floating mode That is a bit surprising. Can look into it later today. Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/20 ------------------------------------------------------------------------ On 2024-11-28T14:05:46+00:00 Robert Mader wrote: > That should work because gecko will not consider the navbar to be opaque due to the rounded clip. Ah, makes sense - so no gtk specific code needed any more, nice. > That is a bit surprising. Can look into it later today. Awesome, thanks! Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/21 ------------------------------------------------------------------------ On 2024-11-28T14:13:36+00:00 Emilio wrote: Seems to work for me on the latest nightly... What am I missing? I still think there's something off about the coordinates tho. Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/22 ------------------------------------------------------------------------ On 2024-11-28T14:18:03+00:00 Emilio wrote: I see it getting unset from time to time tho... will dig. Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/23 ------------------------------------------------------------------------ On 2024-11-28T14:23:28+00:00 Robert Mader wrote: (In reply to Emilio Cobos Álvarez (:emilio) from comment #17) > Seems to work for me on the latest nightly... What am I missing? I still > think there's something off about the coordinates tho. Oh wild - refreshed nightly and now it works for me as well. Sorry, never mind then - and the patch here should fix the last issue \o/ Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/24 ------------------------------------------------------------------------ On 2024-11-28T14:29:55+00:00 Emilio wrote: Created attachment 9440512 Screenshot of nightly + patch on a 100%-scale display. Yeah the main issue seems to be that the coordinates are off by the DPI ratio. follow-up tho. Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/25 ------------------------------------------------------------------------ On 2024-11-28T14:51:57+00:00 Pulsebot-d wrote: Pushed by ealva...@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09d5e4c40ab5 Remove titlebar special-case for opaque region handling. r=rmader Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/26 ------------------------------------------------------------------------ On 2024-11-28T21:59:53+00:00 Abutkovits wrote: https://hg.mozilla.org/mozilla-central/rev/09d5e4c40ab5 Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/27 ------------------------------------------------------------------------ On 2024-11-29T12:02:19+00:00 Release-mgmt-account-bot wrote: The patch landed in nightly and beta is affected. :emilio, is this bug important enough to require an uplift? - If yes, please nominate the patch for beta approval. - If no, please set `status-firefox134` to `wontfix`. For more information, please visit [BugBot documentation](https://wiki.mozilla.org/BugBot#uplift_beta.py). Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/28 ------------------------------------------------------------------------ On 2024-11-29T12:12:11+00:00 Robert Mader wrote: Thanks Emilio, I can confirm that latest nigthly works as expected. Crucially direct-scanout works again in fullscreen (on compositors/displays that don't support transparent overlay planes). Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/29 ------------------------------------------------------------------------ On 2024-11-29T13:36:22+00:00 Emilio wrote: This needs bug 1908471 to be effective, so probably not worth uplifting. Reply at: https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2078774/comments/30 ** Changed in: firefox Status: Unknown => Fix Released ** Bug watch added: Mozilla Bugzilla #1891414 https://bugzilla.mozilla.org/show_bug.cgi?id=1891414 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/2078774 Title: Fullscreen Firefox is not being rendered as direct scanout in GNOME 46/47 Status in Mozilla Firefox: Fix Released Status in Mutter: Fix Released Status in firefox package in Ubuntu: Confirmed Status in mutter package in Ubuntu: Triaged Bug description: Fullscreen Firefox is not being rendered as direct scanout in GNOME 47. Press Alt+F2, type "lg", click Flags and enable PAINT_DAMAGE_REGION. This will show you in red when part of the screen is being composited. When an app is getting fullscreen direct scanout, all redness should go away. It does for Chrome, but not for Firefox. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/2078774/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
