> + # Race condition may happen and the test fails. This only happens in > Jammy containers. > + # Disable the test for now. > + return
I don't think it's appropriate to disable a test without an analysis that considers what it was testing, how to mitigate the gap created by disabling the test or an explanation of why it isn't necessary to run the test. We also need to make arrangements to ensure that a future SRU or security update of this package will make the same mitigation. In the lack of such an analysis or a proper fix, if it only sometimes fails, wouldn't it be better to just retry a few times to land the SRU? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to ubuntu-drivers-common in Ubuntu. https://bugs.launchpad.net/bugs/2077654 Title: Race condition on builders result in 100% fail rate Status in ubuntu-drivers-common package in Ubuntu: New Status in ubuntu-drivers-common source package in Jammy: New Bug description: [ Impact ] ADT testing fails on arm builders [ Test Plan ] Run ADT tests in PPA or locally with: PYTHONPATH=. python3 tests/run test_ubuntu_drivers.DetectTest.test_system_driver_packages_force_install_nvidia The error message to look for is: ====================================================================== FAIL: test_system_driver_packages_force_install_nvidia (test_ubuntu_drivers.DetectTest) system_driver_packages() force install config points to an older version. ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib/python3.10/unittest/mock.py", line 1379, in patched return func(*newargs, **newkeywargs) File "/home/ubuntu/ubuntu-drivers-common-0.9.6.2~0.22.04.6~ppa0/tests/test_ubuntu_drivers.py", line 1479, in test_system_driver_packages_force_install_nvidia self.assertFalse('nvidia-driver-510' in res_wrong_json) AssertionError: True is not false [ Where problems could occur ] during ADT testing on builders [ Other Info ] Cause unknown. It sometimes fails when locally on x86 machine but only in Jammy container. Jammy package ran in Noble container does not fail. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/2077654/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
