** Tags removed: block-proposed-mantic
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to network-manager in Ubuntu.
https://bugs.launchpad.net/bugs/2040292
Title:
network-manager SRU flags system for restart required but also
restarted the service
Status in network-manager package in Ubuntu:
Triaged
Status in network-manager source package in Mantic:
New
Bug description:
[ Impact ]
* During an upgrade (or installation) of the network-manager package, its
debian/network-manager.postinst maintainer script restarts
NetworkManager.service and also requests users to reboot their system.
* It requests a reboot, by calling into
/usr/share/update-notifier/notify-reboot-required and listing "network-manager"
in /var/run/reboot-required.pkgs
* Restarting the systemd service AND asking for a reboot isn't needed. Just
the service restart is enough and we shouldn't ask for a reboot as that is bad
UX
[ Test Plan ]
* Reboot your system (or clear /var/run/reboot-required.pkgs)
echo "" | sudo tee /var/run/reboot-required.pkgs
* Install network-manager from mantic-proposed
apt install [--reinstall] -t mantic-proposed network-manager
* Observe that the NetworkManager.service was restarted by this operation:
"active (running) [...] 2 min ago"
systemctl status Networkmanager.service
● NetworkManager.service - Network Manager
Loaded: loaded (/lib/systemd/system/NetworkManager.service; enabled;
preset: enabled)
Active: active (running) since Wed 2023-10-25 15:21:27 CEST; 2min ago
Docs: man:NetworkManager(8)
Main PID: 3880250 (NetworkManager)
Tasks: 4 (limit: 28344)
Memory: 6.1M
CPU: 425ms
CGroup: /system.slice/NetworkManager.service
└─3880250 /usr/sbin/NetworkManager --no-daemon
* Observe that network-manager was NOT written to
/var/run/reboot-required.pkgs
cat /var/run/reboot-required.pkgs
* Observe that no GUI popped up asking you for a reboot because of
NetworkManager
[ Where problems could occur ]
* This change is touching a maintainer script (.postinst)
* Failures or syntax errors could leave the network-manager package
unconfigured
* It could break installation of the network-manager package
[ Other Info ]
* This SRU should probably just be staged, using `block-proposed-mantic` and
bundled with the next upload.
=== original description ===
After applying the network-manager SRU in mantic, I get a notification
that a system restart is required to fully apply updates.
This immediately raised a question, because I KNOW my network
connection was restarted when the SRU was installed (I have a VPN that
did not auto-reconnect).
And I checked the state of the process - it was definitely restarted
and is running from the binary currently on disk.
The network-manager postinst has the following code:
# request a reboot (NM tears down interfaces on restart
# which is not the way we want to go)
[ -x /usr/share/update-notifier/notify-reboot-required ] && \
/usr/share/update-notifier/notify-reboot-required
But the service restart is also happening. debian/rules currently has:
override_dh_installsystemd:
dh_installsystemd -pnetwork-manager --no-start
NetworkManager-dispatcher.service NetworkManager-wait-online.service
nm-priv-helper.service
dh_installsystemd -pnetwork-manager --no-also NetworkManager.service
No other systemd overrides. Nothing inhibits the restart of the
service.
It needs to be one or the other. And if we're doing SRUs of network-
manager, then this is bad UX for users applying their daily updates
and should be fixed in SRU.
ProblemType: Bug
DistroRelease: Ubuntu 23.10
Package: network-manager 1.44.2-1ubuntu1.1
ProcVersionSignature: Ubuntu 6.5.0-9.9-generic 6.5.3
Uname: Linux 6.5.0-9-generic x86_64
NonfreeKernelModules: zfs
ApportVersion: 2.27.0-0ubuntu5
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: ubuntu:GNOME
Date: Tue Oct 24 08:19:38 2023
InstallationDate: Installed on 2019-12-23 (1401 days ago)
InstallationMedia: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191017)
RebootRequiredPkgs: Error: path contained symlinks.
SourcePackage: network-manager
UpgradeStatus: Upgraded to mantic on 2023-10-16 (8 days ago)
nmcli-nm:
RUNNING VERSION STATE STARTUP CONNECTIVITY NETWORKING WIFI-HW
WIFI WWAN-HW WWAN
running 1.44.2 connected started full enabled enabled
enabled missing enabled
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/2040292/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
