Hello Gabriel, or anyone else affected,

Accepted adsys into focal-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/adsys/0.9.2~20.04 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: adsys (Ubuntu Focal)
       Status: New => Fix Committed

** Tags added: verification-needed-focal

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to adsys in Ubuntu.
https://bugs.launchpad.net/bugs/1982347

Title:
  Username is case sensitive when applying policies on login

Status in adsys package in Ubuntu:
  Fix Released
Status in adsys source package in Focal:
  Fix Committed
Status in adsys source package in Jammy:
  Fix Committed

Bug description:
  [Impact]

  When logging in (either via login or ssh) to an AD account using
  different case combinations, adsysd uses the specified account name
  instead of the lowercase one reported by getent/whoami to apply the
  GPOs. I believe this comes from the pam_get_item call here:
  
https://github.com/ubuntu/adsys/blob/e3316e5e37970a07f09fa6df553ddac096c91255/pam/pam_adsys.c#L266

  This works but has the unintended side effect of producing multiple
  dconf profile files for each variant of the username, and caching
  policies as well:

  root@ubuntu2204:~# ls /etc/dconf/profile/ | grep -i administrator
  [email protected]
  [email protected]
  [email protected]

  root@ubuntu2204:~# ls /var/cache/adsys/policies/ | grep -i administrator
  [email protected]
  [email protected]
  [email protected]

  Of course this all stems from the username retrieved by PAM so there
  might be more unintended side-effects, the dconf one being the easiest
  to observe.

  To ensure an unified experience, when a target name is normalized from
  e.g. DOMAIN\User to User@DOMAIN, it will also be lowercased.

  [Test Plan]

  Reproduction:
  * With adsys set up, log in on the Ubuntu client using an AD account, 
alternating cases
  * Observe multiple files created at /var/cache/adsys/policies

  With the fix applied, remove *all* cached policies at
  /var/cache/adsys/policies and attempt to login with different case
  combinations of the AD account, e.g.:

  [email protected]
  [email protected]
  [email protected]
  [email protected]

  As root, check the contents of /var/cache/adsys/policies - you should
  only see a lowercase entry: [email protected]

  
  [Where problems could occur]

  Target name normalization is exercised by the code that dumps policies
  applied for a given user, and by the code that updates or creates a
  policy for a given user. If this happens to cause a bug, it will
  render the core part of adsys unusable.

  We believe this is highly unlikely given that in some cases, adsys
  already used the lowercase variant of the username to apply and
  display policies.

  [Other Info]

  This issue was initially reported on GitHub at
  https://github.com/ubuntu/adsys/issues/378

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1982347/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to