Hello Andreas, or anyone else affected,

Accepted adsys into focal-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/adsys/0.9.2~20.04 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: adsys (Ubuntu Focal)
       Status: New => Fix Committed

** Tags added: verification-needed verification-needed-focal

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to adsys in Ubuntu.
https://bugs.launchpad.net/bugs/1962170

Title:
  DEP8 failure with samba 4.15.5

Status in adsys package in Ubuntu:
  Fix Released
Status in adsys source package in Focal:
  Fix Committed

Bug description:
  [Impact]
  Tests are failing with the samba version in jammy. We want people using focal 
be able to upgrade to newer samba and still be compatible with adsys.

  [Test Plan]
  1. Ensure that DEP8 tests are passing once uploaded to proposed and ready to 
be migrated

  [Where problems could occur]
  The functionalities failing are only on tests running (DEP8 or tests during 
package builds), but we want to be able to run our tests with newer versions of 
samba on focal too without regressing existing testsuite.

  
  --------------

  The DEP8 tests of adsys started to fail[1] with my samba 4.15.5
  upload.

  Some hints:

  <didrocks> ahasenack: it seems we can’t start our smbd local daemon to
  simulate Active Directory smb server

  <didrocks> ahasenack: yeah, I’m puzzled because on smbd start failure, we do 
print stderr (not stdout though): 
https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L16
  <didrocks> 
https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L43 in 
particular
  <didrocks> you can see here how we start it: 
https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L21
  <didrocks> and the config template is at 
https://github.com/ubuntu/adsys/blob/20e6f962eb87f667f5e29800be0715ab2496a10d/internal/testutils/samba.go#L55
  <ahasenack> 2022/02/24 03:13:59 Setup: smbd hasn’t started successfully
  <ahasenack> that's here: 
https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L129
  <ahasenack> you wait for the port to be open?
  <ahasenack> which port is that, 445/tcp?
  <didrocks> we wait on the port to be opened, and this one is passed as a 
parameter, see the template. For the argument we pass in ad tests, once sec, 
looking
  <didrocks> 1446
  <didrocks> 
https://github.com/ubuntu/adsys/blob/20e6f962eb87f667f5e29800be0715ab2496a10d/cmd/integration_tests/adsys_test.go#L47

  <didrocks> you just need to run go test . in internal/ad/
  <didrocks> the failure is as the pre-test setup

  1. https://autopkgtest.ubuntu.com/results/autopkgtest-
  jammy/jammy/amd64/a/adsys/20220224_031434_4d453@/log.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to