> Therefore the functionality of all other portals should be thoroughly
tested to ensure there are no functional regressions.

This seems sensible, so, please add this to the Test Plan.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to xdg-desktop-portal in Ubuntu.
https://bugs.launchpad.net/bugs/1978295

Title:
  org.freedesktop.portal.OpenURI.OpenDirectory doesn't highlight the
  selected file

Status in xdg-desktop-portal package in Ubuntu:
  Fix Released
Status in xdg-desktop-portal source package in Focal:
  Fix Committed

Bug description:
  [Impact]

   * The OpenDirectory method of the OpenURI portal opens a file manager
  window showing the requested directory, but it doesn't select the
  passed file in that directory. This affects all users of this API,
  particularly the chromium and firefox snaps.

   * This is an upstream bug that was fixed in later versions of xdg-
  desktop-portal, this SRU backports the fix to the 1.6 series that's in
  focal.

  [Test Plan]

   * On a focal machine, install the chromium snap, launch it and download any 
file from a web page (from e.g. https://kernel.org/)
   * Once the download is complete, browse to chrome://downloads
   * Click the "Show in folder" link for the downloaded file, this opens a 
Nautilus window showing the contents of the default downloads directory (e.g. 
$HOME/Downloads)
   * Expected result: the downloaded file is selected in the Nautilus window
   * Actual result without the patch: no file is selected

   * Similarly for the firefox snap, downloading a file and clicking the
  "Show in Folder" button in the downloads panel should select the
  downloaded file

  [Where problems could occur]

   * The backported patches potentially affect other portals (not just 
OpenURI), including the Wallpaper portal.
   * Therefore the functionality of all other portals should be thoroughly 
tested to ensure there are no functional regressions.

  
  [Other Info]
   
   * The firefox snap wasn't using this API before version 103.0, which at the 
time of writing this hasn't officially been released yet (it is due for release 
tomorrow, 2022-07-26). In the meantime it can be installed from the candidate 
channel.

  
  [Original Description]

  This is an upstream issue (https://github.com/flatpak/xdg-desktop-
  portal/issues/564) that was fixed in xdg-desktop-portal 1.10.0.

  I'm proposing to SRU the corresponding patch to focal. This will be
  especially useful for browsers packaged as snaps (see bug #1887195 for
  chromium, and https://bugzilla.mozilla.org/show_bug.cgi?id=1772063 for
  firefox).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xdg-desktop-portal/+bug/1978295/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to