Hello sam, or anyone else affected,

Accepted gvfs into focal-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/gvfs/1.44.1-1ubuntu1.1
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: gvfs (Ubuntu Focal)
       Status: Incomplete => Fix Committed

** Tags added: verification-needed verification-needed-focal

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gvfs in Ubuntu.
https://bugs.launchpad.net/bugs/1927100

Title:
  Slow file dialogs, open and save

Status in gvfs package in Ubuntu:
  Fix Released
Status in gvfs source package in Focal:
  Fix Committed

Bug description:
  [Description/Impact]
  glib GFileMonitors can cause deadlocks if not explicitly cancelled before 
unref-ing (as of Dec 2021; see 
https://gitlab.gnome.org/GNOME/glib/-/issues/1941). In gvfs <1.46.2, 
gvfsd-trash can cause this deadlock, leading to 25s delays in spawning gtk+ 
dialogs system-wide. The best userspace workaround is explicitly pkill-ing 
gvfsd-trash at a sometimes frequent interval.

  This issue was reported and fixed in gvfs
  issue: https://gitlab.gnome.org/GNOME/gvfs/-/issues/485
  commit: 
https://gitlab.gnome.org/GNOME/gvfs/-/commit/dc21a0948bcbe8a6d79d674bd1e4d63ded57d340
  merge: https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/96

  [Test Case]
  To my knowledge, there is not a 100% reproducer for gvfs from userspace as 
this is a probable lock-ordering issue in lower-level code. 
https://gitlab.gnome.org/GNOME/glib/-/issues/1941 contains a reproducer for the 
underlying glib issue.

  User reports of gvfsd-trash manifesting this deadlock exist for Focal and 
Focal-based distributions, and it has been acknowledged and worked-around in 
gvfs. See:
  https://forums.linuxmint.com/viewtopic.php?f=47&t=328966 (Linux Mint forums)
  https://github.com/linuxmint/nemo/issues/2497 (Linux Mint nemo -- file 
manager)
  https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 (gvfs bug report, includes 
diagnosis and stacktrace showing the gvfsd-trash thread)

  The code change patched-in here has propagated to various other projects. See:
  https://bugs.launchpad.net/ubuntu/+source/libxmlb/+bug/1890313
  https://github.com/fwupd/fwupd/issues/2350

  [Regression Potential]
  This patch explicitly cancels GFileMonitors before "unreferencing" them to 
workaround a known glib issue. Absent any currently-unknown issues with the 
GFileMonitor framework, code added by this patch should be entirely within 
valid usage of GFileMonitors, is already present in gvfs releases in wide 
distribution, and, at worst, should become superfluous if/when the underlying 
glib issue is fixed.

  In the event that gvfsd-trash had some (currently unknown)
  mismanagement of its file watchers, it's possible that attempting to
  cancel an invalid monitor might behave differently than unref-ing it
  (which was already happening), but, this scenario would likely be bad
  either way.

  [Original Description]

  On Ubuntu Mate 20.04.

  Sometime the Open and Save dialogs in GTK applications will over 20
  seconds to display.

  I found https://gitlab.gnome.org/GNOME/gvfs/-/issues/485 , which
  suggested this due to gvfsd-trash, and running `killall gvfsd-trash`
  which does temporary solve the problem.

  The issue is apparently fixed in gvfs 1.46.2

  Please could 1.46.2 or the fix
  https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/96 be backported
  to Ubuntu 20.04

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gvfs/+bug/1927100/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to