I tested this and it worked!

- Made an initial backup, not saving password.
- Backed up again, changing the password.

With the old version, I got an error at "verify the backup" step. But
the backup files did end up being written with the wrong password.

With the new version, it did not accept the wrong password and re-
prompted me for the password (correct behavior).

Thank you for uploading the fix!

** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done-bionic

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to duplicity in Ubuntu.
https://bugs.launchpad.net/bugs/918489

Title:
  duplicity allows a new, different passphrase if an archive cache
  exists

Status in Déjà Dup:
  Fix Released
Status in Duplicity:
  Fix Released
Status in deja-dup package in Ubuntu:
  Fix Released
Status in duplicity package in Ubuntu:
  Fix Released
Status in deja-dup source package in Trusty:
  Fix Released
Status in duplicity source package in Trusty:
  Won't Fix
Status in deja-dup source package in Xenial:
  Fix Released
Status in duplicity source package in Xenial:
  Won't Fix
Status in deja-dup source package in Yakkety:
  Fix Released
Status in duplicity source package in Yakkety:
  Won't Fix
Status in deja-dup source package in Bionic:
  Fix Committed
Status in duplicity source package in Bionic:
  Won't Fix

Bug description:
  when doing a backup for the first time, dejadup verifies your
  passphrase by having you enter it twice.

  on future incremental backups it doesn't need to do this because
  entering the wrong password will result in the backup failing.

  with the periodic 'full' backups that happen from time to time,
  however, any password will be accepted.

  this can lead to a situation where you accidentally type the wrong
  password once and are left in a situation where you don't know what
  you typed and have no way to get your files (or do another incremental
  backup on top of it).

  i think this is what happened to me recently.

  clearly, the fix is to explicitly verify the passphrase is correct
  when doing a new full backup.  this may be a duplicity bug.

  === Ubuntu deja-dup SRU information ===

  [impact]
  Users may unwittingly re-set their backup password and not be able to restore 
their data.

  [test case]
  - $ deja-dup-preferences # set up a dummy backup
  - $ deja-dup --backup # complete first encrypted full backup
  - $ rename 's/\.2016/\.2000/' /path/to/test/backup/*
  - $ rename 's/\.2016/\.2000/' ~/.cache/deja-dup/*/*
  - $ deja-dup --backup # second backup, enter the wrong password
  - $ deja-dup --restore # try to restore with original password

  [regression potential]
  Should be limited?  The fix is to delete the duplicity cache files, which 
ought to be safe to delete.

  It's possible if a full backup is being resumed, we might delete the
  current progress.  That is a better bug to have than this bug, though.
  A more complicated patch would need to be investigated to prevent
  that.

To manage notifications about this bug go to:
https://bugs.launchpad.net/deja-dup/+bug/918489/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to