> 3) Add a bunch of mappings from SIM->Carrier > Assuming (3) is not expected to change existing behaviour this looks like it would be acceptable under the hardware-enablement SRU policy.
Agreed, but I would expect SRU information against every change being made, that would then receive separate SRU verification. This helps us mitigate risk by 1) actually considering each change in the first place, rather than it "slipping past" review; and 2) reducing the potential number of SRUs, and therefore user time, bandwidth and regression risk, by actually verifying that things are being changed as expected so we don't have to do it twice. I'm disappointed that this has now gone through two SRU review rounds, and it is Chris who has extracted the actual nature of the changes that you are looking to land here. This detail should have been laid out in the bug (or multiple bugs) and in the SRU information in the first place. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to modemmanager in Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. Status in OEM Priority Project: In Progress Status in modemmanager package in Ubuntu: New Bug description: [Impact] The modem certification requires that different modem firmware is used for different network carrier. This needs the firmware upgrading capability during the modem certification process. The modem manufacture vendors (Foxconn and Quectel) provided utilities to do modem's firmware upgrading manually.(LP#1943774, LP#1943780) These utilities are verified to be working when the recent versions(> v 1.18.2) of ModemManager are used with. To support manual firmware upgrading on the current Focal release which is using ModemManager v 1.16.6, we need to apply some patches from v 1.18.2. The requested upstream patches are listed as below: * for Quectel EM160 4G ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/83ac82470589a3672092a0ba0be855093b1cf5e2 * for Foxconn T99W175 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/21ae558fe3600c84b3ca7dcd9bf50a3ba576c7c9 **https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/76e700f4fd703f952208993330ab098305c13d6b ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/52bf2c641171ded9e617022f40497c8984520371 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/33e2b023ef01bea9da37ae2beb192f7d92bce47a ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/f72046701659073fbfa97516e155865647acb154 The firmware upgrading was verified using the patched ModemManager v 1.16.6 with the following 2 modems: * Foxconn SDX55 T99W175 5G sub6 PCIE Modem * Quectel SDX24 EM160R-GL 4G LTE CAT16 PCIE Modem [Test Plan] 1. Install the Ubuntu image. 2. Boot and login the system. 3. Prepare the modem’s firmware and install the firmware upgrading application provided by Foxconn and Quectel 4. Using the firmware upgrading application to upgrade the modem’s firmware 5. Verify if the modem’s firmware upgrading is successful 6. Reboot 7. Verify if the upgraded modem firmware is still working [Where problems could occur] The requested upstream patches are for these 2 specific modems. This should not affect existing generic functions and other modems. [Other Info] The firmware and the upgrading utilities can be downloaded from the following link: * LP#1943774 for Quectel modems * LP#1943780 for Foxconn modems To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp