SRU review I don't see any explanation of what this is fixing, or why this is needed, so cannot review if the proposed changes qualify for an SRU under Ubuntu's policies.
Specifically I need an explanation of actual user impact, not just "fix some problems". Further, note that the procedure says "Do not create a meta-bug with a title like "Please SRU this" rather than using existing bug reports". We need actual public bugs for each of the specific problems that you're fixing. Each of those bugs should be linked from the changelog, so we can ensure during SRU verification that each of those issues have individually been verified fixed. Done properly, there is then no need for a meta bug like this one. See https://wiki.ubuntu.com/StableReleaseUpdates#Procedure for full details on what is expected. The Focal upload is also missing a proper bug reference - the reference given doesn't match the standard pattern so didn't get copied to the Launchpad-Bugs-Fixed header. I'm rejecting both the Hirsute and Focal uploads since both uploads need their changelogs fixing to properly reference public bugs that contain full SRU information. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to modemmanager in Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Apply upstream patches to fix problems for Foxconn and Quectel modems. Status in OEM Priority Project: In Progress Status in modemmanager package in Ubuntu: Fix Committed Bug description: [Impact] The following 2 modems need the ModemManager v1.16.6 suite to be patched from v1.18.2 to fix some problems(LP#1943774, LP#1943780): * Foxconn SDX55 T99W175 5G sub6 PCIE Modem * Quectel SDX24 EM160R-GL 4G LTE CAT16 PCIE Modem The requested upstream patches are listed as below: * for Quectel EM160 4G ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/83ac82470589a3672092a0ba0be855093b1cf5e2 * for Foxconn T99W175 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/21ae558fe3600c84b3ca7dcd9bf50a3ba576c7c9 **https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/76e700f4fd703f952208993330ab098305c13d6b ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/52bf2c641171ded9e617022f40497c8984520371 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/33e2b023ef01bea9da37ae2beb192f7d92bce47a ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/f72046701659073fbfa97516e155865647acb154 [Test Plan] 1. Install the Ubuntu image. 2. Boot and login the system. 3. Prepare the modem’s firmware and install the firmware upgrading application provided by Foxconn and Quectel 4. Using the firmware upgrading application to upgrade the modem’s firmware 5. Verify if the modem’s firmware upgrading is successful 6. Reboot 7. Verify if the upgraded modem firmware is still working [Where problems could occur] The requested upstream patches are for these 2 specific modems and the status information. This should not affect existing generic functions and other modems. [Other Info] The firmware and the upgrading application can be downloaded from the following link: * LP#1943774 for Quectel modems * LP#1943780 for Foxconn modems To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
