Hello riu, or anyone else affected,

Accepted gnome-shell-extension-desktop-icons into focal-proposed. The
package will build now and be available at
https://launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-
icons/20.04.0-3~ubuntu20.04.1 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Tags added: verification-needed verification-needed-focal

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-shell-extension-desktop-icons in
Ubuntu.
https://bugs.launchpad.net/bugs/1880031

Title:
  Thumbnail is stretched if its aspect ratio is less than that of the
  container

Status in gnome-shell-extension-desktop-icons:
  Unknown
Status in gnome-shell-extension-desktop-icons package in Ubuntu:
  Fix Released
Status in gnome-shell-extension-desktop-icons source package in Focal:
  Fix Committed

Bug description:
  [ Impact ]

  Image thumbnails are stretched if the aspect ratio is less than the
  one of the container

  [ Test case ]

  To reproduce, create an image that has aspect ratio, e.g., ~0.5 (e.g.
  width = 250 and height = 500)

  Save it in the desktop and ensure that the image has proper
  proportions.

  
  [ Regression potential ]

  Image thumbnails are distorted

  ----

  This was discovered when investigating fix for bug #1868529.

  Aspect ratio is still not correct for images that are more narrow than
  the container. To reproduce, create an image that has aspect ratio,
  e.g., ~0.5 (e.g. width = 250 and height = 500).

  Line in fileItem.js where we calculate icon width does not count the
  margins (zero is used instead of actual margins):

  let containerWidth = Prefs.getDesiredWidth(scaleFactor, 0);

  Here is how the margins are being calculated in desktopGrid.js:

          this._extra_width = themeNode.get_margin(St.Side.LEFT) +
                               themeNode.get_margin(St.Side.RIGHT) +
                               themeNode.get_border_width(St.Side.LEFT) +
                               themeNode.get_border_width(St.Side.RIGHT) +
                               themeNode.get_horizontal_padding();
          this._extra_height = themeNode.get_margin(St.Side.TOP) +
                               themeNode.get_margin(St.Side.BOTTOM) +
                               themeNode.get_border_width(St.Side.TOP) +
                               themeNode.get_border_width(St.Side.BOTTOM) +
                               themeNode.get_vertical_padding();

To manage notifications about this bug go to:
https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to