Hey Olivier! I looked at the librsvg upload in the queue just now. I'm a
bit worried about the symbols removal in librsvg2-2. Looking at the
diff:
diff -Nru librsvg-2.48.2/debian/librsvg2-2.symbols
librsvg-2.48.7/debian/librsvg2-2.symbols
--- librsvg-2.48.2/debian/librsvg2-2.symbols 2020-04-07 20:23:36.000000000
+0000
+++ librsvg-2.48.7/debian/librsvg2-2.symbols 2020-06-19 21:19:37.000000000
+0000
@@ -55,8 +55,6 @@
rsvg_rust_handle_get_base_url@Base 2.46.0
rsvg_rust_handle_get_dimensions@Base 2.46.0
rsvg_rust_handle_get_dimensions_sub@Base 2.46.0
- rsvg_rust_handle_get_dpi_x@Base 2.46.0
- rsvg_rust_handle_get_dpi_y@Base 2.46.0
rsvg_rust_handle_get_geometry_for_element@Base 2.46.0
rsvg_rust_handle_get_geometry_for_layer@Base 2.46.0
rsvg_rust_handle_get_intrinsic_dimensions@Base 2.46.0
@@ -76,8 +74,7 @@
rsvg_rust_handle_render_layer@Base 2.46.0
rsvg_rust_handle_set_base_gfile@Base 2.46.0
rsvg_rust_handle_set_base_url@Base 2.46.0
- rsvg_rust_handle_set_dpi_x@Base 2.46.0
- rsvg_rust_handle_set_dpi_y@Base 2.46.0
+ rsvg_rust_handle_set_dpi_x_y@Base 2.48.5
rsvg_rust_handle_set_size_callback@Base 2.46.0
rsvg_rust_handle_set_stylesheet@Base 2.47.3
rsvg_rust_handle_set_testing@Base 2.46.0
Doesn't his break the current ABI? Those seem to be public symbols that
are being removed. Doesn't this warrant a librsvg soname bump, to
something like librsvg2-3 or something? I'm worried about this breaking
existing applications.
Was this investigated? Am I just being overly paranoid?
** Changed in: librsvg (Ubuntu Focal)
Status: Fix Committed => Incomplete
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to librsvg in Ubuntu.
https://bugs.launchpad.net/bugs/1884326
Title:
SRU the current 2.48.7 stable update
Status in librsvg package in Ubuntu:
Fix Released
Status in librsvg source package in Focal:
Incomplete
Bug description:
* Impact
That's the current GNOME stable update, which fixes a number of issues:
https://gitlab.gnome.org/GNOME/librsvg/-/blob/librsvg-2.48/NEWS
* Test case
The update is part of GNOME stable updates
https://wiki.ubuntu.com/StableReleaseUpdates/GNOME
Smoke testing by opening SVG images with eog or importing them with
gimp can be performed to ensure there are no regressions.
* Regression potential
This is a bugfix-only stable micro-release, however librsvg is a core
component with a number of reverse dependencies. A combination of
autopkgtests and manual smoke testing to try and detect SVG rendering
issues should be performed.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/librsvg/+bug/1884326/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
