** Description changed: + [Impact] + + Minor. Apparently under certain circumstances "xdg-settings get default-web-browser" can return an empty string (although I haven't been able to reproduce this myself), and this will make the /usr/bin/chromium-browser wrapper script spit out a console error (but it won't prevent it from running the browser). + This is trivial to fix by enclosing the call to "xdg-settings get default-web-browser" in double quotes, to cater for the empty result case (see https://bazaar.launchpad.net/~chromium-team/chromium-browser/eoan-stable/revision/1526). + + + [Test Case] + + 1. Install chromium-browser + 2. Patch /usr/bin/xdg-settings to make the get_browser_gnome3() function return an empty string (replace its body with 'echo ""') + 3. From a terminal, run "chromium-browser" + + Expected result: no error + Current result: /usr/bin/chromium-browser: 12: [: =: unexpected operator + + + [Regression Potential] + + Low, enclosing a call to a command in double quotes in bash shouldn't + have any undesirable side effect, and that's all that the patch does. + + + [Original Description] + Hi, here is the error: - $ chromium-browser + $ chromium-browser /usr/bin/chromium-browser: 12: [: =: unexpected operator [...] Here is line 12 in /usr/bin/chromium-browser: if [ $(xdg-settings get default-web-browser) = "chromium- browser.desktop" ]; then The error occurs because on my system the default-web-browser setting is unset: $ xdg-settings get default-web-browser [nothing] I suggest putting double quotes around: if [ "$(xdg-settings get default-web-browser)" = "chromium- browser.desktop" ]; then ProblemType: Bug DistroRelease: Ubuntu 19.10 Package: chromium-browser 77.0.3865.120-0ubuntu1.19.10.1 Uname: Linux 5.3.12-050312-generic x86_64 ApportVersion: 2.20.11-0ubuntu8.3 Architecture: amd64 CurrentDesktop: KDE DRM.card0-DP-1: - enabled: disabled - dpms: Off - status: disconnected - edid-base64: - modes: + enabled: disabled + dpms: Off + status: disconnected + edid-base64: + modes: DRM.card0-HDMI-A-1: - enabled: disabled - dpms: Off - status: disconnected - edid-base64: - modes: + enabled: disabled + dpms: Off + status: disconnected + edid-base64: + modes: DRM.card0-HDMI-A-2: - enabled: disabled - dpms: Off - status: disconnected - edid-base64: - modes: + enabled: disabled + dpms: Off + status: disconnected + edid-base64: + modes: DRM.card0-eDP-1: - enabled: enabled - dpms: On - status: connected - edid-base64: AP///////wAJ5csGAAAAAAEaAQSVIhN4CvmglV1ZlCkkUFQAAAABAQEBAQEBAQEBAQEBAQEBGjuAJHE4PEAwIDYAWMIQAAAa/S2ADnE4KEAwIDYAWMIQAAAaAAAA/gBSTUpDWYBOVjE1TjQyAAAAAAAAQSKWABAAAAoBCiAgAMg= - modes: 1920x1080 1920x1080 + enabled: enabled + dpms: On + status: connected + edid-base64: AP///////wAJ5csGAAAAAAEaAQSVIhN4CvmglV1ZlCkkUFQAAAABAQEBAQEBAQEBAQEBAQEBGjuAJHE4PEAwIDYAWMIQAAAa/S2ADnE4KEAwIDYAWMIQAAAaAAAA/gBSTUpDWYBOVjE1TjQyAAAAAAAAQSKWABAAAAoBCiAgAMg= + modes: 1920x1080 1920x1080 Date: Fri Nov 22 10:27:14 2019 DiskUsage: - Filesystem Type Size Used Avail Use% Mounted on - /dev/mapper/MonVolume2-UbuntuRacine ext4 492G 235G 232G 51% / - tmpfs tmpfs 7.8G 124M 7.7G 2% /dev/shm - /dev/mapper/MonVolume2-UbuntuRacine ext4 492G 235G 232G 51% / + Filesystem Type Size Used Avail Use% Mounted on + /dev/mapper/MonVolume2-UbuntuRacine ext4 492G 235G 232G 51% / + tmpfs tmpfs 7.8G 124M 7.7G 2% /dev/shm + /dev/mapper/MonVolume2-UbuntuRacine ext4 492G 235G 232G 51% / Lsusb: - Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub - Bus 001 Device 003: ID 0bda:58f6 Realtek Semiconductor Corp. Integrated_Webcam_HD - Bus 001 Device 002: ID 046d:c03e Logitech, Inc. Premium Optical Wheel Mouse (M-BT58) - Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub + Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub + Bus 001 Device 003: ID 0bda:58f6 Realtek Semiconductor Corp. Integrated_Webcam_HD + Bus 001 Device 002: ID 046d:c03e Logitech, Inc. Premium Optical Wheel Mouse (M-BT58) + Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub MachineType: Dell Inc. Latitude 5590 ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-5.3.12-050312-generic root=/dev/mapper/MonVolume2-UbuntuRacine ro vsyscall=none security=apparmor intel_iommu=on quiet splash vt.handoff=7 Snap.ChromeDriverVersion: ChromeDriver 78.0.3904.108 (4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}) Snap.ChromiumVersion: - /bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) - Chromium 78.0.3904.108 snap + /bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) + Chromium 78.0.3904.108 snap SourcePackage: chromium-browser UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 07/19/2019 dmi.bios.vendor: Dell Inc. dmi.bios.version: 1.10.1 dmi.board.name: 0VYDFF dmi.board.vendor: Dell Inc. dmi.board.version: A00 dmi.chassis.type: 10 dmi.chassis.vendor: Dell Inc. dmi.modalias: dmi:bvnDellInc.:bvr1.10.1:bd07/19/2019:svnDellInc.:pnLatitude5590:pvr:rvnDellInc.:rn0VYDFF:rvrA00:cvnDellInc.:ct10:cvr: dmi.product.family: Latitude dmi.product.name: Latitude 5590 dmi.product.sku: 0817 dmi.sys.vendor: Dell Inc.
-- You received this bug notification because you are a member of Desktop Packages, which is subscribed to chromium-browser in Ubuntu. https://bugs.launchpad.net/bugs/1853574 Title: Syntax error in /usr/bin/chromium-browser when xdg-settings get default-web-browser is empty Status in chromium-browser package in Ubuntu: Fix Released Status in chromium-browser source package in Eoan: In Progress Bug description: [Impact] Minor. Apparently under certain circumstances "xdg-settings get default-web-browser" can return an empty string (although I haven't been able to reproduce this myself), and this will make the /usr/bin/chromium-browser wrapper script spit out a console error (but it won't prevent it from running the browser). This is trivial to fix by enclosing the call to "xdg-settings get default-web-browser" in double quotes, to cater for the empty result case (see https://bazaar.launchpad.net/~chromium-team/chromium-browser/eoan-stable/revision/1526). [Test Case] 1. Install chromium-browser 2. Patch /usr/bin/xdg-settings to make the get_browser_gnome3() function return an empty string (replace its body with 'echo ""') 3. From a terminal, run "chromium-browser" Expected result: no error Current result: /usr/bin/chromium-browser: 12: [: =: unexpected operator [Regression Potential] Low, enclosing a call to a command in double quotes in bash shouldn't have any undesirable side effect, and that's all that the patch does. [Original Description] Hi, here is the error: $ chromium-browser /usr/bin/chromium-browser: 12: [: =: unexpected operator [...] Here is line 12 in /usr/bin/chromium-browser: if [ $(xdg-settings get default-web-browser) = "chromium- browser.desktop" ]; then The error occurs because on my system the default-web-browser setting is unset: $ xdg-settings get default-web-browser [nothing] I suggest putting double quotes around: if [ "$(xdg-settings get default-web-browser)" = "chromium- browser.desktop" ]; then ProblemType: Bug DistroRelease: Ubuntu 19.10 Package: chromium-browser 77.0.3865.120-0ubuntu1.19.10.1 Uname: Linux 5.3.12-050312-generic x86_64 ApportVersion: 2.20.11-0ubuntu8.3 Architecture: amd64 CurrentDesktop: KDE DRM.card0-DP-1: enabled: disabled dpms: Off status: disconnected edid-base64: modes: DRM.card0-HDMI-A-1: enabled: disabled dpms: Off status: disconnected edid-base64: modes: DRM.card0-HDMI-A-2: enabled: disabled dpms: Off status: disconnected edid-base64: modes: DRM.card0-eDP-1: enabled: enabled dpms: On status: connected edid-base64: AP///////wAJ5csGAAAAAAEaAQSVIhN4CvmglV1ZlCkkUFQAAAABAQEBAQEBAQEBAQEBAQEBGjuAJHE4PEAwIDYAWMIQAAAa/S2ADnE4KEAwIDYAWMIQAAAaAAAA/gBSTUpDWYBOVjE1TjQyAAAAAAAAQSKWABAAAAoBCiAgAMg= modes: 1920x1080 1920x1080 Date: Fri Nov 22 10:27:14 2019 DiskUsage: Filesystem Type Size Used Avail Use% Mounted on /dev/mapper/MonVolume2-UbuntuRacine ext4 492G 235G 232G 51% / tmpfs tmpfs 7.8G 124M 7.7G 2% /dev/shm /dev/mapper/MonVolume2-UbuntuRacine ext4 492G 235G 232G 51% / Lsusb: Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub Bus 001 Device 003: ID 0bda:58f6 Realtek Semiconductor Corp. Integrated_Webcam_HD Bus 001 Device 002: ID 046d:c03e Logitech, Inc. Premium Optical Wheel Mouse (M-BT58) Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub MachineType: Dell Inc. Latitude 5590 ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-5.3.12-050312-generic root=/dev/mapper/MonVolume2-UbuntuRacine ro vsyscall=none security=apparmor intel_iommu=on quiet splash vt.handoff=7 Snap.ChromeDriverVersion: ChromeDriver 78.0.3904.108 (4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}) Snap.ChromiumVersion: /bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) Chromium 78.0.3904.108 snap SourcePackage: chromium-browser UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 07/19/2019 dmi.bios.vendor: Dell Inc. dmi.bios.version: 1.10.1 dmi.board.name: 0VYDFF dmi.board.vendor: Dell Inc. dmi.board.version: A00 dmi.chassis.type: 10 dmi.chassis.vendor: Dell Inc. dmi.modalias: dmi:bvnDellInc.:bvr1.10.1:bd07/19/2019:svnDellInc.:pnLatitude5590:pvr:rvnDellInc.:rn0VYDFF:rvrA00:cvnDellInc.:ct10:cvr: dmi.product.family: Latitude dmi.product.name: Latitude 5590 dmi.product.sku: 0817 dmi.sys.vendor: Dell Inc. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1853574/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
