I tested version 19.01.3-1~ubuntu19.04.1 (from -proposed) on a fully updated 19.04, and can no longer reproduce this issue: The terminal window opens - as expected - in directory ~/Desktop/aaa'bbb/. Injecting commands as discussed in comment 2 appears to be no longer possible.
** Tags removed: verification-needed verification-needed-disco ** Tags added: verification-done verification-done-disco -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-shell-extension-desktop-icons in Ubuntu. https://bugs.launchpad.net/bugs/1825396 Title: "Open in Terminal" returns "Text ended before matching quote was found for '" Status in gnome-shell-extension-desktop-icons: Fix Released Status in gnome-shell-extension-desktop-icons package in Ubuntu: Fix Released Status in gnome-shell-extension-desktop-icons source package in Disco: Fix Committed Bug description: [ Description ] Attempting to open a Desktop folder named "aaa'bbb" (without double quotes) using the "Open in Terminal" option from the context menu produces a notification message stating: Execution of "x-terminal-emulator --working-directory=/home/... Text ended before matching quote was found for '. (The text was "x-terminal-emulator --working-directory=/home/x/Desktop/aaa'bbb") This suggests improper escaping (possible security impact with command injection). [ QA ] Steps to reproduce: 1. On the Ubuntu 19.04.0 amd64 Desktop, right-click, and select "New folder" 2. Enter the following folder name and press Enter: aaa'bbb 3. Right-click on the newly created folder icon 4. Select "Open in Terminal" 5. The above notification pops up, no terminal window opens. The expected outcome would be: 5. A terminal window opens in directory ~/Desktop/aaa'bbb [ Regression potential ] See bug #1829244 [ ... ] ProblemType: Bug DistroRelease: Ubuntu 19.04 Package: gnome-shell-extension-desktop-icons 19.01.1-1 ProcVersionSignature: Ubuntu 5.0.0-13.14-generic 5.0.6 Uname: Linux 5.0.0-13-generic x86_64 ApportVersion: 2.20.10-0ubuntu27 Architecture: amd64 CurrentDesktop: ubuntu:GNOME Date: Thu Apr 18 18:40:28 2019 InstallationDate: Installed on 2019-04-14 (4 days ago) InstallationMedia: Ubuntu 19.04 "Disco Dingo" - Alpha amd64 (20190413.2) PackageArchitecture: all SourcePackage: gnome-shell-extension-desktop-icons UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1825396/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
