Hi everyone,
I don't know which is the right place to post this, but the discussion
here seems to be the most appropriate for bringing this up.
I looked more into the tilix warnings. After all, the warnings seem to be
caused by the vte lib and especially in the reverted parts.
Therefore, I downloaded the source with apt-get source libvte-2.91-0 and
printed the arguments of line 1906 which triggers the warnings.
#include <stdio.h> (at the top of the file)
printf("arguments: %d %d %d\n", g_regex_get_compile_flags(gregex),
G_REGEX_MULTILINE,
g_regex_get_compile_flags(gregex) &
G_REGEX_MULTILINE);
So I started tilix and looked at the output:
arguments: 1 2 0
(tilix:5596): Vte-WARNING **: 10:32:57.957: (../../src/vtegtk.cc:1905):int
vte_terminal_match_add_gregex(VteTerminal*, GRegex*, GRegexMatchFlags): runtime
check failed: (g_regex_get_compile_flags(gregex) & G_REGEX_MULTILINE)
warning should be printed
arguments: 1 2 0
(tilix:5596): Vte-WARNING **: 10:32:57.957: (../../src/vtegtk.cc:1905):int
vte_terminal_match_add_gregex(VteTerminal*, GRegex*, GRegexMatchFlags): runtime
check failed: (g_regex_get_compile_flags(gregex) & G_REGEX_MULTILINE)
warning should be printed
arguments: 1 2 0
(tilix:5596): Vte-WARNING **: 10:32:57.957: (../../src/vtegtk.cc:1905):int
vte_terminal_match_add_gregex(VteTerminal*, GRegex*, GRegexMatchFlags): runtime
check failed: (g_regex_get_compile_flags(gregex) & G_REGEX_MULTILINE)
warning should be printed
arguments: 1 2 0
(tilix:5596): Vte-WARNING **: 10:32:57.957: (../../src/vtegtk.cc:1905):int
vte_terminal_match_add_gregex(VteTerminal*, GRegex*, GRegexMatchFlags): runtime
check failed: (g_regex_get_compile_flags(gregex) & G_REGEX_MULTILINE)
warning should be printed
arguments: 1 2 0
(tilix:5596): Vte-WARNING **: 10:32:57.957: (../../src/vtegtk.cc:1905):int
vte_terminal_match_add_gregex(VteTerminal*, GRegex*, GRegexMatchFlags): runtime
check failed: (g_regex_get_compile_flags(gregex) & G_REGEX_MULTILINE)
warning should be printed
arguments: 1 2 0
(tilix:5596): Vte-WARNING **: 10:32:57.957: (../../src/vtegtk.cc:1905):int
vte_terminal_match_add_gregex(VteTerminal*, GRegex*, GRegexMatchFlags): runtime
check failed: (g_regex_get_compile_flags(gregex) & G_REGEX_MULTILINE)
warning should be printed
As you can see both arguments itself are true. But why is a "bitwise and" used
in g_warn_if_fail()? Since the first is 1 and the second 2, this causes
00000010 & 00000001 -> 00000000 and the warning is triggered?
So what I did and propose is to replace the "bitwise and" with a
"logical or". This causes that the warning is only triggered if one of
both arguments is false. -> The tilix warning is gone and everything
seems work for me!
This line is created by the ubuntu specific patch "revert-pcre2.patch"
and in this file in line 1065
Just for letting you know which part of tilix calls this function:
In the constructor in the file terminal.d the function applyPreferences() is
called. There in the switch statement
the case SETTINGS_ALL_CUSTOM_HYPERLINK_KEY is calling loadRegex() which calls
the vte function vte_terminal_match_add_gregex 6 times and triggers the 6
warnings.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-terminal in Ubuntu.
https://bugs.launchpad.net/bugs/1666264
Title:
FFe: Update gnome-terminal to 3.24 and vte to 0.48
Status in gnome-terminal package in Ubuntu:
Fix Released
Status in vte2.91 package in Ubuntu:
Fix Released
Bug description:
gnome-terminal and vte are still at their 3.20 (and 0.44) versions
because they now hard-depend on pcre2, but the pcre2 MIR (LP:
#1636666) has stalled because there is already one version of pcre in
main and it would be a major task to convert all of main to use pcre2.
So I reverted 3 commits for gnome-terminal and 5 for vte to make that
MIR less urgent. I am concerned about the long-term maintainability of
this approach - the vte patch is over 1600 lines.
gnome-terminal 3.22 and vte 0.46 have been tested in the GNOME3
Staging PPA for yakkety and zesty for months. I am not aware of any
issues from that. This is slightly different since I haven't tested
those versions without pcre2 until this weekend.
The development cycle for gnome-terminal and vte has been fairly quiet
so I believe it's safe to go ahead and update gnome-terminal to
3.23.90 and vte to 0.47.90.
https://git.gnome.org/browse/gnome-terminal/log
https://git.gnome.org/browse/vte/log
The packages are currently available for testing at
https://launchpad.net/~gnome3-team/+archive/ubuntu/gnome3-staging/+packages?field.series_filter=zesty
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/1666264/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
