I agree it's a nice idea.

One nitpick: All the source code goes right next to handling LP regexes,
so I'd place and number the patch itself in the "series" file right next
to it, too.

This patch would be useful for Debian too, but they don't have
60_add_lp_handler.patch which this patch builds on.

Perhaps their order should be swapped, so that CVE comes first, and this
is the one that converts the body of action_copy_match_cb() into an "if"
branch. Then LP comes on top of this for Ubuntu only.

Indeed Debian and Ubuntu would use different URLs for CVEs. Maybe you
could make the patch itself the same, using a macro passed to
configure/make, or define that in another one-liner patch. Not sure if
that simplifies anything in your build systems, just a simple idea up
for you to consider.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-terminal in Ubuntu.
https://bugs.launchpad.net/bugs/1775329

Title:
  Feature request: Add a handler for CVE URLs

Status in gnome-terminal package in Ubuntu:
  Triaged
Status in gnome-terminal source package in Bionic:
  Triaged

Bug description:
  Provide automatic link handling for CVE identifiers back to the Ubuntu
  Security team's CVE database (useful when looking at package
  changelog's which have security fixes etc).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/1775329/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to