Public bug reported:

budgie-desktop should display GNOME based CSD headerbars.

Due to the patching, it displays non GNOME based menus.

Attached is a patch to resolve this.  It has been tested on multiple
desktop environments;

It correctly displays a traditional menu bar for Unity.

For both GNOME-Shell and budgie-desktop CSD is displayed.

Note - I have taken the clean and consistent approach as the patching
for gedit.

The extant traditional and unity patches are confused - DESKTOP_SESSION
comparison is hard-coded for GNOME - budgie-desktop uses the
DESKTOP_SESSION of BUDGIE:GNOME.  The traditional menu bar patch is
inconsistent and uses a completely different algorithm that doesnt work
with budgie-desktop.

I have simplified the logic to just apply CSD for GNOME based desktops
as per gedit patching.

** Affects: evince (Ubuntu)
     Importance: Undecided
     Assignee: fossfreedom (fossfreedom)
         Status: In Progress


** Tags: zesty

** Patch added: "evince_3.22.1-2ubuntu2.debdiff"
   
https://bugs.launchpad.net/bugs/1670054/+attachment/4831571/+files/evince_3.22.1-2ubuntu2.debdiff

** Changed in: evince (Ubuntu)
       Status: New => In Progress

** Changed in: evince (Ubuntu)
     Assignee: (unassigned) => fossfreedom (fossfreedom)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to evince in Ubuntu.
https://bugs.launchpad.net/bugs/1670054

Title:
  evince should display CSD headerbars for budgie-desktop

Status in evince package in Ubuntu:
  In Progress

Bug description:
  budgie-desktop should display GNOME based CSD headerbars.

  Due to the patching, it displays non GNOME based menus.

  Attached is a patch to resolve this.  It has been tested on multiple
  desktop environments;

  It correctly displays a traditional menu bar for Unity.

  For both GNOME-Shell and budgie-desktop CSD is displayed.

  Note - I have taken the clean and consistent approach as the patching
  for gedit.

  The extant traditional and unity patches are confused -
  DESKTOP_SESSION comparison is hard-coded for GNOME - budgie-desktop
  uses the DESKTOP_SESSION of BUDGIE:GNOME.  The traditional menu bar
  patch is inconsistent and uses a completely different algorithm that
  doesnt work with budgie-desktop.

  I have simplified the logic to just apply CSD for GNOME based desktops
  as per gedit patching.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/evince/+bug/1670054/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to