(In reply to Markus Keller from comment #58) > (In reply to Eclipse Genie from comment #53) > > Gerrit change https://git.eclipse.org/r/50125 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=3db87a8763e3fd3f931295da165ddee8363a7b16 > > > > The Widget#valueContainsFlag(..) doesn't meet SWT's coding style and quality > standards: > > - The standard idiom in SWT is this: > > if ((keymask & (OS.GDK_MOD1_MASK | OS.GDK_SHIFT_MASK > | OS.GDK_CONTROL_MASK | OS.GDK_SUPER_MASK > | OS.GDK_META_MASK | OS.GDK_HYPER_MASK)) != 0) { > sendTreeDefaultSelection(); > } > > Also note the position of the '{'.
Thank you for feedback. I've made the relevant refactoring and tested for functionality. (removed valueContainsFlag() method). I added you as reviewer: https://git.eclipse.org/r/#/c/51524/ Please let me know if there's anything else. > The valueContainsFlag method should be removed again. If it would have been > kept, the following would have had to be fixed: > > - Why is the type of 'value' long and not int? > - Missing @return description. > - Typo: Convienience (please check why you didn't see an error underline > from the spell checker) To this I shall link to this tweet: https://twitter.com/iamdevloper/status/614509767747178499 (On the side: I did have spell check turned on, but it seems by default Eclipse only picks up the first 100 spell check errors. The function being at the bottom of a 2000+ widget, Eclipse didn't get to the typo. I set my preferences to 9999 instead now) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to eclipse in Ubuntu. https://bugs.launchpad.net/bugs/586910 Title: Java editor view has no focus after double-clicking a java file Status in Eclipse: Confirmed Status in eclipse package in Ubuntu: Confirmed Bug description: Binary package hint: eclipse Steps to reproduce: 1. in the Package explorer, double-click on a Java file 2. press CTRL + F to search for some string in the file Expected results: A Java editor view gets opened. The Java editor view gets the focus, and CTRL + F opens the find/replace dialog for that file. Actual results: A Java editor view gets opened. Focus however stays at the Package explorer view, and CTRL + F opens some search field for the Package explorer. This worked fine with the Eclipse in Kubuntu 9.10. In addition, Zend Studio for Eclipse also is affected. This worked fine in Zend Studios for Eclipse 7.12 on Kubuntu 9.10, and after re- installing Kubuntu 10.04 (and copying back my home directory which also includes Zend Studio), this was broken. I've also filed this in the Eclipse bug tracker, but the Eclipse folk says that this probably is "buried lower": https://bugs.eclipse.org/bugs/show_bug.cgi?id=312568 Launchpad issue #237819 sounds a bit similar, but I'm not quite sure about this. ProblemType: Bug DistroRelease: Ubuntu 10.04 Package: eclipse 3.5.2-2ubuntu4.1 ProcVersionSignature: Ubuntu 2.6.32-22.33-generic-pae 2.6.32.11+drm33.2 Uname: Linux 2.6.32-22-generic-pae i686 Architecture: i386 Date: Fri May 28 19:14:42 2010 InstallationMedia: Kubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100427) PackageArchitecture: all ProcEnviron: LANGUAGE= PATH=(custom, user) LANG=de_DE.UTF-8 SHELL=/bin/bash SourcePackage: eclipse workspace.metadata.log: xulrunner-versions: /usr/lib/xulrunner-1.9.2.3 To manage notifications about this bug go to: https://bugs.launchpad.net/eclipse-eclipsers/+bug/586910/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
