Comment on attachment 8553148
Possible patch
Review of attachment 8553148:
-----------------------------------------------------------------
Sorry for the delayed review!
UI-Review:
------------
Minor Nits:
- "Customize From Address" is confusing. “Enter a custom address” perhaps?
- If you choose a custom address (which focuses the field), and then you
deselect the field, and click it again, we should show the drop down (don't
keep it editable).
Significant Problems:
- What if users try to use it as a separate address and they don’t actually
have the account added to TB. Any replies to it will never show up.
* (I'm thinking of naive users who think they can enter whatever address they
"own" here without bothering to add the actual account, and expect us to add it
automatically or something.
- What server are we actually sending this message through? We should probably
have some capability to choose which one.
- Is this going to encourage spam sending? I can send a message as
“barackob...@usa.gov” now. I understand the capability was there already, but
now it’s going to be even easier to do. This feature could be seriously abused.
Conclusion:
Is this feature too accessible? Should we hide this ability somehow? I can
definitely see its value, but perhaps we need a pref for it.
I like the drop down UI though, just needs an option to pick the server.
Review:
------------
::: mail/components/compose/content/messengercompose.xul
@@ +171,5 @@
>
> <command id="cmd_convertCloud"
> oncommand="convertSelectedToCloudAttachment(event.target.cloudProvider);
> event.stopPropagation();"/>
> <command id="cmd_convertAttachment"
> oncommand="goDoCommand('cmd_convertAttachment')"/>
> <command id="cmd_cancelUpload"
> oncommand="goDoCommand('cmd_cancelUpload')"/>
> + <command id="cmd_customiseFromAddress" oncommand="MakeFromFieldEditable();"
*customize please. :)
@@ +172,5 @@
> <command id="cmd_convertCloud"
> oncommand="convertSelectedToCloudAttachment(event.target.cloudProvider);
> event.stopPropagation();"/>
> <command id="cmd_convertAttachment"
> oncommand="goDoCommand('cmd_convertAttachment')"/>
> <command id="cmd_cancelUpload"
> oncommand="goDoCommand('cmd_cancelUpload')"/>
> + <command id="cmd_customiseFromAddress" oncommand="MakeFromFieldEditable();"
> + label="&customiseFromAddress.label;"/>
Ditto.
::: mail/locales/en-US/chrome/messenger/messengercompose/messengercompose.dtd
@@ +302,5 @@
>
> <!-- Title for the address picker panel -->
> <!ENTITY addressesSidebarTitle.label "Contacts">
>
> +<!-- Identity popup customise menuitem -->
Ditto.
@@ +303,5 @@
> <!-- Title for the address picker panel -->
> <!ENTITY addressesSidebarTitle.label "Contacts">
>
> +<!-- Identity popup customise menuitem -->
> +<!ENTITY customiseFromAddress.label "Customize From Address">
Ditto.
::: mailnews/compose/src/nsMsgCompose.cpp
@@ +1066,5 @@
> + nsCString sender;
> + MakeMimeAddress(NS_ConvertUTF16toUTF8(fullName), email, sender);
> + m_compFields->SetFrom(sender.IsEmpty() ? email.get() : sender.get());
> + }
> +
All of this is unnecessary now because of your backend changes landing.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the "From" field for the current email only (as text, not
dropdown)
Status in Mozilla Thunderbird Mail and News:
Confirmed
Status in thunderbird package in Ubuntu:
Triaged
Bug description:
Binary package hint: thunderbird
I want to quite often use a particular email address (e.g. for writing
to a mailing list), where I do not have added the email address to the
account settings yet.
However, Thunderbird does not allow to edit the From field, but only
provides the configured email addresses in a dropdown.
It would be nice, if you could also edit the From field in a text
input.
KMail provides this, for example, and there appear to be some
extensions for it, but I'd like to avoid using an addon for this, but
rather think it's a nice feature to have by default.
I could imagine, that the last entry in the dropdown would say
"Edit..." or "Custom..." and change the dropdown into a text field.
ProblemType: Bug
Architecture: i386
DistroRelease: Ubuntu 9.04
NonfreeKernelModules: nvidia
Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
PackageArchitecture: all
ProcEnviron:
PATH=(custom, user)
LANG=de_DE.UTF-8
SHELL=/bin/bash
SourcePackage: thunderbird
Uname: Linux 2.6.28-11-generic i686
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
