Created attachment 827318
PoC patch for both winless and windowed plugins. (Windows)

This proposal is a sensible workaround (as a "complete" solution would
require the collaboration of every single plugin developer, which
doesn't seem feasible) for Windows. Is my understanding that OSX is
not affected, and a solution already exists for GNU/Linux, please
correct me if I'm wrong.

I've implemented two different strategies, one for plugins running in
its own window, and the other for the winless ones. The first one
installs a keyboard hook, which looks for well known keystrokes, and
passes the focus to the main window when one is found. The second
passes all key events to both the plugin and the DOM, except for the
ones which generates movement events (arrow keys, space,
pageup/pagedown...).

This patch is intended as a Proof-of-Concept, it needs betters
comments, an approved list of keystrokes to watch, and (probably) the
ability to be enabled/disabled via "about:config". But I wanted to
obtain early feedback from the devs prior to investing more work on
it.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to flashplugin-nonfree in Ubuntu.
https://bugs.launchpad.net/bugs/263435

Title:
  Firefox cannot close tab (using Ctrl-w) when flash content is selected
  on page

Status in The Mozilla Firefox Browser:
  Confirmed
Status in “firefox-3.0” package in Ubuntu:
  Confirmed
Status in “flashplugin-nonfree” package in Ubuntu:
  Opinion

Bug description:
  Binary package hint: flashplugin-nonfree

  Firefox cannot close tab (using Ctrl-w) or switch to next tab (using
  Ctrl-Tab) when flash content is selected on page.

  Steps to reproduce:
  1) Open a new Tab
  2) Go to a website with flash content (in this case youtube.com)
  3) Selected the flash content by clicking on it (in this case click on play)
  4) While the content plays, press a keyboard shortcut (in this case Ctrl-w to 
close the tab)

  Result: The shortcut is not registered by firefox, the tab remains open
  Expectation: The shortcut should be registered by firefox, the tab should 
close

  A good way of knowing that "selecting the flash content" is at the
  root of the problem: if you select a part of the page that is not
  flash content (in this case empty white space at the right or the left
  of the video) followed by Ctrl-W, the tab closes.

  Version Information:
  Ubuntu Hardy (2.6.24-19-generic)
  firefox 3.0.1+build1+nobinonly-0ubuntu0.8.04.3
  flashplugin-nonfree 9.0.124.0ubuntu2

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/263435/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to