Comment on attachment 675468 call DiscardNewMessage properly, only update size when downloading full message
Review of attachment 675468: ----------------------------------------------------------------- This looks fine afaict. It seems to do the right things and doesn't break existing tests. ::: mailnews/base/util/nsMsgDBFolder.cpp @@ +1721,5 @@ > + ReleaseSemaphore(static_cast<nsIMsgFolder*>(this)); > + if (msgStore) > + // this closes the stream > + msgStore->DiscardNewMessage(m_tempMessageStream, m_offlineHeader); > + else nit: blank space on end of line ::: mailnews/imap/src/nsImapProtocol.cpp @@ +3270,5 @@ > > if (NS_SUCCEEDED(rv)) > ParseIMAPandCheckForNewMail(commandString.get()); > GetServerStateParser().SetFetchingFlags(false); > + m_fetchingWholeMessage = false; For the two false cases, please can you include the comment: // Always clear this flag after every fetch. as I think it'll just help make it a bit more sense (and reflects what was there before) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/1068921 Title: Mailbox grows endlessly, heavy traffic Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Status in “thunderbird” source package in Lucid: Triaged Status in “thunderbird” source package in Natty: Triaged Status in “thunderbird” source package in Oneiric: Triaged Status in “thunderbird” source package in Precise: Triaged Status in “thunderbird” source package in Quantal: Triaged Bug description: Yesterday I noticed that my Internet connection keeps transferring a lot of data. After a while I checked with nethogs and discovered this was caused by Thunderbird. Today I got a warning that my HDD was near full. In this 2 days, the mailbox had grown to 20 GB, while in reality it should be around 1 GB (a fresh zipped backup has 600 MB). I removed the .thunderbird folder and configured my IMAP mailbox from scratch. The same happened again. I think this is not related to a somehow special configuration of my PC bcs my colleague discovered it's the same on his machine. Without checking, he wouldn't have noticed yet bcs of a much bigger HDD... We couldn't yet find out what exactly happens / which data is transferred again and again. I suspect it's related to the last thunderbird update. Ubuntu 12.04 Tunderbird 16.0.1+build1-0ubuntu0.12.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/1068921/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
