Launchpad has imported 8 comments from the remote bug at
https://bugs.freedesktop.org/show_bug.cgi?id=50415.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2012-05-28T08:17:18+00:00 Pmladek-y wrote:

Created attachment 62153
Screenthot showing the problem

The strings describing menu shortcuts are not longer localized in
LO-3.5.4 on Linux.

Steps to reproduce:

1. run libreoffice in German locales, for example:
   LANG=de_DE.UTF-8 libreoffice3.6
2. Open the menu "Datei"  (File)
3. See the shortcut for "Speichern unter" (Save as)

Result: "Control+Shift+S"

Expected result: "Ctrl+Maiusc+S"
 
It is a regression in 3.5.4. It worked well in LO-.3.5.3.

It is most likely caused by
http://cgit.freedesktop.org/libreoffice/core/commit/vcl?h=libreoffice-3-5-4&id=8d9e2d9a211f710e91ac7c607fea25895282d245

Reply at: https://bugs.launchpad.net/df-
libreoffice/+bug/1007291/comments/0

------------------------------------------------------------------------
On 2012-05-28T08:19:10+00:00 Pmladek-y wrote:

Bjorn, Arnold, could we revert the commit or somehow fix it?

Reply at: https://bugs.launchpad.net/df-
libreoffice/+bug/1007291/comments/1

------------------------------------------------------------------------
On 2012-05-28T19:48:07+00:00 Valter Mura wrote:

Created attachment 62178
Screenshot for the Italian UI

Reply at: https://bugs.launchpad.net/df-
libreoffice/+bug/1007291/comments/2

------------------------------------------------------------------------
On 2012-05-29T09:22:25+00:00 Björn Michaelsen wrote:

I have no instant idea for a fix.

Well, since the commit en passant fixed this crasher (thanks to Caolan
for noting):

 https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/818761

I wonder which is more valuable: localized shortcuts or a crasher.

IMHO keeping the crasher out, which might cause data-loss, even if it is
rare, should have priority.

Of course, for 3.6 we need a sane fix anyway.

Reply at: https://bugs.launchpad.net/df-
libreoffice/+bug/1007291/comments/3

------------------------------------------------------------------------
On 2012-05-30T16:48:11+00:00 Uckcd-shokah-f0mkz wrote:

Petr, with LANG=de_DE.UTF-8 libreoffice3.6 you can't reproduce this bug.
Try this with libreoffice 3.5.3 and it will fail too. The translation of
those keys was dependent on the keyboard layout, not the locale setting.
As Bjoern mentioned in his commit:

lp#818761: removing the problematic call to GetKeyboardName() as
getKeysymReplacementName only provides the name of the key named
as given by the l10n of the _keyboard_ (not the locale) e.g. a
german keyboard would name "Ctrl" instead as "Strg". Assuming
this change to be safe as getKeysymReplacementName falls back to
English names anyway.

The replacement table was called with
::vcl_sal::getKeysymReplacementName.

On master I deleted the table:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2233aa52da14ec85331aee1163b885fe9a9fb507

The problem itself lies at SalDisplay::GetKeyboardName:

// try X keyboard extension
if( (pXkbDesc = XkbGetKeyboard( GetDisplay(), XkbAllComponentsMask, 
XkbUseCoreKbd )) )
{
const char* pAtom = NULL;
if( pXkbDesc->names->groups[0] )
{
    pAtom = XGetAtomName( GetDisplay(), pXkbDesc->names->groups[0] );
    m_aKeyboardName = pAtom;
    XFree( (void*)pAtom );
}

--> The keyboard name was extracted from the current keyboard layout. So
you have to change your keyboard layout to get a translation of keys
with libo 3.5.3.

Reply at: https://bugs.launchpad.net/df-
libreoffice/+bug/1007291/comments/4

------------------------------------------------------------------------
On 2012-05-30T16:49:15+00:00 Uckcd-shokah-f0mkz wrote:

Created attachment 62294
Output of SalDisplay::GetKeyboardName

Use: gcc -L /usr/lib/X11/ -lX11 -o keysym keysym.c

Reply at: https://bugs.launchpad.net/df-
libreoffice/+bug/1007291/comments/5

------------------------------------------------------------------------
On 2012-05-31T16:49:38+00:00 Pmladek-y wrote:

Created attachment 62341
Screenshots with German UI and German keyboard on Linux. It shows the 
differences between 3.5.3 and 3.5.4.

I am sorry, I am probably dumb. Please look at the attached screenshot
and see the differences between LibreOffice-3.5.3 and 3.5.4 on Linux.

I have started the application the following way:

export LANG=de_DE.UTF-8
setxkbmap de
libreoffice3.6

I guess that 3.5.4 is wrong. I do not have a real German keyboard around
but I guess that the physical key has the label "Strg" and not "Ctrl".
So, German users might have troubles to find the "Ctrl" key by their
fingers.

Or did I miss something? How should I do the right test?

Reply at: https://bugs.launchpad.net/df-
libreoffice/+bug/1007291/comments/6

------------------------------------------------------------------------
On 2012-06-01T11:17:40+00:00 Björn Michaelsen wrote:

possibly related:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1007320

Reply at: https://bugs.launchpad.net/df-
libreoffice/+bug/1007291/comments/9


** Changed in: df-libreoffice
       Status: Unknown => Confirmed

** Changed in: df-libreoffice
   Importance: Unknown => High

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to libreoffice in Ubuntu.
https://bugs.launchpad.net/bugs/1007291

Title:
  [upstream] German language pack: "Control", "Shift" in menus
  untranslated

Status in LibreOffice Productivity Suite:
  Confirmed
Status in “libreoffice” package in Ubuntu:
  New

Bug description:
  In the German language pack, the modifier keys "Control" and "Shift"
  that appear in the menus remain untranslated. They should read "Strg"
  and "Umschalt".

  ProblemType: Bug
  DistroRelease: Ubuntu 12.04
  Package: libreoffice-l10n-de 1:3.5.3-0ubuntu1
  Uname: Linux 3.4.0-030400-generic-pae i686
  ApportVersion: 2.0.1-0ubuntu7
  Architecture: i386
  Date: Fri Jun  1 09:50:39 2012
  InstallationMedia: Kubuntu 12.04 LTS "Precise Pangolin" - Release i386 
(20120423)
  PackageArchitecture: all
  ProcEnviron:
   LANGUAGE=
   TERM=xterm
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: libreoffice
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/1007291/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to