The problem stems from "darkMode-Add-support-to-Yaru-theme-color- variants.patch" patch, applied to gnome-shell. The issue lies with the "_setYaruSettings()" function.
This function is only called if the current GTK theme is "Yaru", however there's no check of the current icon theme. "_setYaruSettings()" starts by awkwardly determining if we're in dark mode or not by checking whether both the gtk-theme *and* the icon-theme end with "-dark". This leads to inconsistent behavior when one of these is changed away from Yaru. Changing the icon theme to something that doesn't end in "-dark" will make it incorrectly assume we're in light mode. But when this code *does* run, it doesn't bother checking the icon theme anyway, it just replaces it with Yaru no matter what. Personally, I think there should be separate checks for both the GTK and icon theme before changing them *individually*, as long as they're already set to a variant of Yaru. Also, Gnome Control Center doesn't seem to have this problem and doesn't override a manually changed theme or icon set. It might be helpful to reference the logic used there, and implement something similar, just for consistency. --- I tried taking a shot at this myself, though I'm not a JavaScript developer. I was able to get it to successfully build, but my attempt at rewriting the logic didn't work right. Ironically though, it has temporarily fixed the bug for me, by virtue of just breaking the Yaru function altogether. I also couldn't make heads or tails of where to begin with actually *submitting* a fix (if I were to debug it more), and I've already spent a bit too much time on this. So, this comment is my contribution instead. For any developer already involved and working on Ubuntu's Gnome Shell patches, this should be something like a fifteen minute fix. It'd be great to see that happen, thanks. =) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/2054856 Title: Icon theme is reset on dark/light theme switch To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/2054856/+subscriptions -- desktop-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
