I posted a comment in the PR above, and I reproduce it here:

"""
I have a question about replacing the `expr "$i" : '^[[:alnum:]_-]\+$'` check 
with `find -type f`. It seems we would start to include files with a dot in 
them with this change:

```
$ l /etc/X11/Xresources/*
-rw-r--r-- 1 root root 319 Oct  9  2020 /etc/X11/Xresources/x11-common

$ expr "x11-common" : '^[[:alnum:]_-]\+$' > /dev/null; echo $?
0

$ expr "x11-common.dpkg-confold" : '^[[:alnum:]_-]\+$' > /dev/null; echo $?
1
```

Since `$sysresources` points `/etc/X11/Xresources`, there could conceivably be 
backup config files in there, which the original expression would be ignoring, 
but not the new `find`. Has this been considered, or am I wrong in my analysis?
"""

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1955850

Title:
  /etc/X11/Xresources no longer loaded, error in patch

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1955850/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Reply via email to