Partial review of the patch so far. I haven't read much openbox code so take this with a grain of salt.
https://bugzilla.icculus.org/show_bug.cgi?id=6669#c9 mentions a concern that itPrev may still be pointing to invalid data. I share this concern. I think some interesting testcases are what happens with lists that have one or two elements, which then are modified by this function. In the single element case, I believe your itPrev now points to the deleted item, and in the two element case, itPrev may be ok but itPrev->prev or itPrev->next are both probably not valid. https://bugzilla.icculus.org/show_bug.cgi?id=6669#c5 mentions a work branch. I suggest tracking that down and considering it. It's presumably this patch https://bugzilla.icculus.org/attachment.cgi?id=3646&action=diff. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/2011751 Title: openbox crashed with SIGABRT To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/2011751/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
