> As you can see both arguments itself are true.

The first two arguments you printed are bitmasks, it doesn't make sense
to directly interpret them as boolean.

> But why is a "bitwise and" used in g_warn_if_fail()?

Because that's what it wants to do: warn if the MULTILINE flag isn't
set, regardless of the other flags.

> So what I did and propose is to replace the "bitwise and" with a
"logical or".

This is semantically absolutely incorrect. The second argument is a
nonzero constant, logically OR-ing would always give logical TRUE, hence
the "warn if fail" not executed.

You could just as well remove the entire line, that'd be okay.

---

Let's take one step back. Comment #17 says "This is still breaking tilix
functionality and polluting the logs" but the tilix bug linked from #19
only talks about the warnings. Maybe I'm missing something, but is
Tilix's actual behavior broken? If so, how exactly, and where's the
tracking Ubuntu bug of that? Or are we only talking about annoying but
harmless warnings?

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-terminal in Ubuntu.
https://bugs.launchpad.net/bugs/1666264

Title:
  FFe: Update gnome-terminal to 3.24 and vte to 0.48

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/1666264/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Reply via email to