Trusty fix uploaded to SRU review queue.

** Description changed:

  When failing to import a module the gi.repository import.py module logs an 
error with `logging.error(..)` causing a logging handler to be added.
  This basically breaks the ability to configure the logging as it happens so 
early (i.e. at the import stage before an authors code is executed).
  
  To reproduce/Example:
  
  Run this script: http://pastebin.ubuntu.com/7698632/
  
  Expected outcome:
  No output to stdout or stderr and the text "log message" in the file 
"/tmp/example.log
  
  Actual outcome:
  No log file, and this text output to stderr:
-   ERROR:root:Could not find any typelib for rubbish
-   ERROR:root:log message
- 
+   ERROR:root:Could not find any typelib for rubbish
+   ERROR:root:log message
  
  Upstream fix: https://git.gnome.org/browse/pygobject/commit/?id=ac8b59e
+ 
+ Regression potential:
+ - The behaviour of raising ImportError on a nonexisting name does not change, 
but its text changes.
+   Old: ImportError: cannot import name 'foo'
+   New: ImportError: cannot import name foo, introspection typelib not found
+ 
+   It's unlikely, however theoretically possible that a program matches
+ on the precise error message.
+ 
+ - It's theoretically possible that a program watches for the logged
+ error message and ignores the ImportError. However, that would be
+ extremely bad design, un-Pythonic and brittle as the logging
+ format/destination can be changed arbitrarily.
+ 
+ In summary the regression potential is very low.
+ 
  
  Ubuntu Version:
  Description:  Ubuntu 14.04 LTS
  Release:      14.04
  
  Package Version:
  python3-gi 3.12.0-1

** Changed in: pygobject (Ubuntu Trusty)
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to pygobject in Ubuntu.
https://bugs.launchpad.net/bugs/1333512

Title:
  Failing to import module breaks logging configurability and adds noise

To manage notifications about this bug go to:
https://bugs.launchpad.net/pygobject/+bug/1333512/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Reply via email to