While working on bug #71160 I've found another regression introduced by
this fix. In some cases, additional lines are added to the selection.
For example, open the hig document and go to the first page. Start
selecting the second line, but dragging from the margin, and you will
see that the first line is selected too. This is because the second line
is more indented than the first one. This fix changed the way blocks and
lines are included in the selection by using the manhattan distance, and
in this case, the distance of the first line is less than the second
line, but the first line doesn't even intersect with the selection
rectangle. If you start the selection closer to the beginning of the
second line, then the first line is not included because distance to the
second line is less in such case.

You can play with it now using the text demo of poppler-glib-demo. I've
added an area selector to get the text of a given area. Try using X1=0,
Y1=122, which should discard the first line, but it doesn't. However
using X1=257, Y1=122 discards the first line entirely.

So, I think that we need to somehow discard blocks and lines that don't
intersect with the selection rectangle even if the manhattan distance is
less than any other block/line.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/33288

Title:
  Evince doesn't handle columns properly

To manage notifications about this bug go to:
https://bugs.launchpad.net/poppler/+bug/33288/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Reply via email to