Dr. Osman, thanks for your patch. A few comments:
1. Of course, this patch does not restore type-ahead find as originally
requested in this bug ticket. Instead, it simply disables recursive
searching, so that as you type only files in the current directory are
returned. Still, this does significantly ease the pain of this upstream
change. If Ubuntu can't summon the resources to restore type-ahead find
in 13.10, I would recommend landing this patch since it's ultra-simple
and does make things less painful. I'd further recommend modifying the
patch so that non-recursive search is the default (as it stands, the
user must set a GSettings key to disable recursive search, and few users
will figure out how to do that). The GSettings key would then let users
*enable* recursive search if they really want to. I suspect that few
users will.
2. You really should be patching Nautilus 3.8.2, which is the current
version of Nautilus in Ubuntu 13.10, where this is most likely to land.
(I wouldn't mind seeing this backported to 13.04 either, though.)
3. In the patch, I believe you could simplify this code:
if (g_settings_get_boolean (nautilus_preferences,
NAUTILUS_PREFERENCES_ENABLE_RECURSIVE_SEARCH)) {
g_object_set (simple_provider, "recursive", TRUE, NULL);}
else
{
g_object_set (simple_provider, "recursive", FALSE, NULL);
}
to:
gboolean recursive = g_settings_get_boolean (nautilus_preferences,
NAUTILUS_PREFERENCES_ENABLE_RECURSIVE_SEARCH));
g_object_set(simple_provider, "recursive", recursive, NULL);
Fewer lines are better. :)
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1164016
Title:
restore type-ahead find
To manage notifications about this bug go to:
https://bugs.launchpad.net/nautilus/+bug/1164016/+subscriptions
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
